You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
_See also: [Flutter's code of conduct](https://flutter.io/design-principles/#code-of-conduct)_
7
7
8
-
Things you will need
9
-
--------------------
8
+
## Things you will need
9
+
10
10
11
11
* Linux, Mac OS X, or Windows.
12
12
* git (used for source version control).
13
13
* An ssh client (used to authenticate with GitHub).
14
14
15
-
Getting the code and configuring your environment
16
-
-------------------------------------------------
15
+
## Getting the code and configuring your environment
16
+
17
17
18
18
* Ensure all the dependencies described in the previous section are installed.
19
19
* Fork `https://github.com/flutter/plugins` into your own GitHub account. If
@@ -29,8 +29,8 @@ Getting the code and configuring your environment
29
29
fetch from the master repository, not your clone, when running `git fetch`
30
30
et al.)
31
31
32
-
Running the examples
33
-
--------------------
32
+
## Running the examples
33
+
34
34
35
35
To run an example with a prebuilt binary from the cloud, switch to that
36
36
example's directory, run `pub get` to make sure its dependencies have been
@@ -40,8 +40,7 @@ USB and debugging enabled on that device.
40
40
*`cd packages/battery/example`
41
41
*`flutter run`
42
42
43
-
Running the tests
44
-
-----------------
43
+
## Running the tests
45
44
46
45
Flutter plugins have both unit tests of their Dart API and integration tests that run on a virtual or actual device.
47
46
@@ -58,8 +57,7 @@ cd example
58
57
flutter drive test/<name_of_plugin>.dart
59
58
```
60
59
61
-
Contributing code
62
-
-----------------
60
+
## Contributing code
63
61
64
62
We gladly accept contributions via GitHub pull requests.
65
63
@@ -112,3 +110,20 @@ You must complete the
112
110
You can do this online, and it only takes a minute.
113
111
If you've never submitted code before, you must add your (or your
114
112
organization's) name and contact info to the [AUTHORS](AUTHORS) file.
113
+
114
+
### The review process
115
+
116
+
* This is a new process we are currently experimenting with, feedback on the process is welcomed at the Gitter contributors channel. *
117
+
118
+
Reviewing PRs often requires a non trivial amount of time. We prioritize issues, not PRs, so that we use our maintainers' time in the most impactful way. Issues pertaining to this repository are managed in the [flutter/flutter issue tracker and are labeled with "plugin"](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3Aplugin+sort%3Areactions-%2B1-desc). Non trivial PRs should have an associated issue that will be used for prioritization. See the [prioritization section](https://github.com/flutter/flutter/wiki/Issue-hygiene#prioritization) in the Flutter wiki to understand how issues are prioritized.
119
+
120
+
Newly opened PRs first go through initial triage which results in one of:
121
+
***Merging the PR** - if the PR can be quickly reviewed and looks good.
122
+
***Closing the PR** - if the PR maintainer decides that the PR should not be merged.
123
+
***Moving the PR to the backlog** - if the review requires non trivial effort and the issue isn't a priority; in this case the maintainer will:
124
+
* Make sure that the PR has an associated issue labeled with "plugin".
125
+
* Add the "backlog" label to the issue.
126
+
* Leave a comment on the PR explaining that the review is not trivial and that the issue will be looked at according to priority order.
127
+
***Starting a non trivial review** - if the review requires non trivial effort and the issue is a priority; in this case the maintainer will:
|[firebase_ml_vision][ml_vision_pub]|![pub package][ml_vision_badge]|[Firebase ML Kit][ml_vision_product]|[`packages/firebase_ml_vision`][ml_vision_code]|
0 commit comments