Skip to content

Give the Optimizely client an interface to facilitate testing #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nevett opened this issue Aug 9, 2018 · 2 comments · Fixed by #93
Closed

Give the Optimizely client an interface to facilitate testing #92

Nevett opened this issue Aug 9, 2018 · 2 comments · Fixed by #93

Comments

@Nevett
Copy link
Contributor

Nevett commented Aug 9, 2018

It is very difficult to write unit tests around our code that makes use of Optimizely, since it provides no interface from which to create a suitable mock. We can make do by creating our own wrapping class, but this gets messy quickly.

Can an IOptimizely interface be added, so that we can use NSubstitute or a similar library to mock the Optimizely client?

@mikeproeng37
Copy link
Contributor

I've closed the PR, but will hold off on closing this until we release. We don't have a date yet, but tentatively within the next few weeks.

@mikeproeng37
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants