From 866562da15337d7270ba448c78eb1df2e5e62877 Mon Sep 17 00:00:00 2001
From: Juan Carlos Tong <juancarlos.tong@optimizely.com>
Date: Fri, 7 Feb 2020 12:38:04 -0800
Subject: [PATCH 1/5] ci(travis): add mdspell
---
.travis.yml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/.travis.yml b/.travis.yml
index f39c377f..00b95edd 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -23,6 +23,18 @@ jobs:
- find . -type f -name '*.md' -exec awesome_bot {} \;
notifications:
email: false
+ - stage: 'Lint markdown files'
+ language: node_js
+ node_js: 12
+ os: linux
+ before_install: skip
+ install:
+ - npm i -g markdown-spellcheck
+ before_script:
+ - wget --quiet https://gist.githubusercontent.com/juancarlostong/dad02feeebc8763af35b4fdc717cf7a2/raw/29e085302a9418edbefba15d8f790fa76e0a89d5/.spelling
+ script:
+ - mdspell -a -n -r --en-us '**/*.md'
+ after_success: skip
- &integrationtest
stage: 'Integration tests'
env: SDK=csharp SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH
From d41e1c5cc756c7d47469ceb1c5a6624d334fc724 Mon Sep 17 00:00:00 2001
From: Juan Carlos Tong <juancarlos.tong@optimizely.com>
Date: Fri, 7 Feb 2020 13:05:47 -0800
Subject: [PATCH 2/5] use latest version of .spelling
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index 00b95edd..3d03b5ce 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -31,7 +31,7 @@ jobs:
install:
- npm i -g markdown-spellcheck
before_script:
- - wget --quiet https://gist.githubusercontent.com/juancarlostong/dad02feeebc8763af35b4fdc717cf7a2/raw/29e085302a9418edbefba15d8f790fa76e0a89d5/.spelling
+ - wget --quiet https://gist.githubusercontent.com/juancarlostong/dad02feeebc8763af35b4fdc717cf7a2/raw/.spelling
script:
- mdspell -a -n -r --en-us '**/*.md'
after_success: skip
From 2ea5baa1aa4d938a8197133b501ac24d4ce58e6a Mon Sep 17 00:00:00 2001
From: Juan Carlos Tong <juancarlos.tong@optimizely.com>
Date: Fri, 7 Feb 2020 13:21:44 -0800
Subject: [PATCH 3/5] spelling fixes
---
CHANGELOG.md | 6 +++---
OptimizelySDK.DemoApp/README.md | 2 +-
OptimizelySDK.DemoApp/Scripts/README.md | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1ff0327b..d9838565 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,7 +8,7 @@ January 23rd, 2020
- Call `GetOptimizelyConfig()` to get a snapshot copy of project configuration static data.
- It returns an `OptimizelyConfig` instance which includes a datafile revision number, all experiments, and feature flags mapped by their key values.
- Added caching for `GetOptimizelyConfig` - `OptimizelyConfig` object will be cached and reused for the lifetime of the datafile
- - For details, refer to a documention page: https://docs.developers.optimizely.com/full-stack/docs/optimizelyconfig-csharp
+ - For details, refer to a documentation page: https://docs.developers.optimizely.com/full-stack/docs/optimizelyconfig-csharp
### Bug Fixes:
- Blocking timeout was not being assigned. When not providing any value, it was just logging not setting up periodinterval and blocking timeout value. [#202](https://github.com/optimizely/csharp-sdk/pull/202)
@@ -23,7 +23,7 @@ September 26th, 2019
- To configure event batching, set the `MaxEventBatchSize` and `MaxEventFlushInterval` properties in the `OptimizelyFactory` using `OptimizelyFactory.SetBatchSize(int batchSize)` and `OptimizelyFactory.SetFlushInterval(TimeSpan flushInterval)` and then creating using `OptimizelyFactory.NewDefaultInstance`.
- Event batching is enabled by default. `eventBatchSize` defaults to `10`. `eventFlushInterval` defaults to `30000` milliseconds.
- Updated the `Dispose` method representing the process of closing the instance. When `Dispose` is called, any events waiting to be sent as part of a batched event request will be immediately batched and sent to the event dispatcher.
-- If any such requests were sent to the event dispatcher, `Stop` waits for provided `TimeoutInterval` before stoping, so that events get successfully dispatched.
+- If any such requests were sent to the event dispatcher, `Stop` waits for provided `TimeoutInterval` before stopping, so that events get successfully dispatched.
- `OptimizelyFactory` now provides support of setting configuration variables from ***App.config***, User will now be able to provide configuration variables of `HttpConfigManager` and `BatchEventProcessor` in ***App.config***. Steps of usage are provided in [README.md](https://github.com/optimizely/csharp-sdk#using-appconfig-in-optimizelyfactory).
### Deprecated
@@ -119,7 +119,7 @@ October 26, 2018
* feat(api): Accepting all types for attributes values ([#102](https://github.com/optimizely/csharp-sdk/pull/102))
### Bug fixes
-* fix(whitelistng): Removed logic from bucketing since it is checked in Decision Service. ([#98](https://github.com/optimizely/csharp-sdk/pull/98))
+* fix(whitelisting): Removed logic from bucketing since it is checked in Decision Service. ([#98](https://github.com/optimizely/csharp-sdk/pull/98))
* fix(track): Send decisions for all experiments using an event when using track. ([#100](https://github.com/optimizely/csharp-sdk/pull/100))
* fix(datafile-parsing): Prevent newer versions datafile ([#101](https://github.com/optimizely/csharp-sdk/pull/101))
* fix(api): Only track attributes with valid attribute types. ([#103](https://github.com/optimizely/csharp-sdk/pull/103))
diff --git a/OptimizelySDK.DemoApp/README.md b/OptimizelySDK.DemoApp/README.md
index fad09a7e..1e3e6b06 100644
--- a/OptimizelySDK.DemoApp/README.md
+++ b/OptimizelySDK.DemoApp/README.md
@@ -24,7 +24,7 @@ Using the instructions below, you can run the app locally and mimic bucketing we
* Metrics: "Overall revenue"
* Event Key: "add_to_cart".
("Create New Event...", "Add to Experiment")
-5. Save and start your experment
+5. Save and start your experiment
("Create Experiment", "Start Experiment")
6. In "Audiences" tab of your project's Optimizely dashboard, create
* 3 Audience attributes "user_id", "user_name", and "age".
diff --git a/OptimizelySDK.DemoApp/Scripts/README.md b/OptimizelySDK.DemoApp/Scripts/README.md
index 7d682faf..ff1e9551 100644
--- a/OptimizelySDK.DemoApp/Scripts/README.md
+++ b/OptimizelySDK.DemoApp/Scripts/README.md
@@ -47,7 +47,7 @@ the poppers.
Some of the key points are:
- Position elements keeping them in their original DOM context (doesn't mess with your DOM!);
-- Allows to export the computed informations to integrate with React and other view libraries;
+- Allows to export the computed information to integrate with React and other view libraries;
- Supports Shadow DOM elements;
- Completely customizable thanks to the modifiers based structure;
@@ -122,7 +122,7 @@ var anotherPopper = new Popper(
### Callbacks
Popper.js supports two kinds of callbacks, the `onCreate` callback is called after
-the popper has been initalized. The `onUpdate` one is called on any subsequent update.
+the popper has been initialized. The `onUpdate` one is called on any subsequent update.
```js
const reference = document.querySelector('.my-button');
From 3e97bc89d8cd2e9579f6a2a693bb778e9c1505a7 Mon Sep 17 00:00:00 2001
From: Juan Carlos Tong <juancarlos.tong@optimizely.com>
Date: Mon, 10 Feb 2020 09:53:30 -0800
Subject: [PATCH 4/5] update source location for .spelling
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index 3d03b5ce..a45c0589 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -31,7 +31,7 @@ jobs:
install:
- npm i -g markdown-spellcheck
before_script:
- - wget --quiet https://gist.githubusercontent.com/juancarlostong/dad02feeebc8763af35b4fdc717cf7a2/raw/.spelling
+ - wget --quiet https://raw.githubusercontent.com/optimizely/mdspell-config/master/.spelling
script:
- mdspell -a -n -r --en-us '**/*.md'
after_success: skip
From 0f69b56a308d48ee8643a0f0adc092e84a59021c Mon Sep 17 00:00:00 2001
From: Juan Carlos Tong <juancarlos.tong@optimizely.com>
Date: Mon, 10 Feb 2020 16:23:42 -0800
Subject: [PATCH 5/5] improves build speed
---
.travis.yml | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index a45c0589..8871ab1d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -15,18 +15,16 @@ stages:
jobs:
include:
- stage: 'Lint markdown files'
- language: ruby
- rvm: 2.4.1
os: linux
+ language: generic
install: gem install awesome_bot
script:
- find . -type f -name '*.md' -exec awesome_bot {} \;
notifications:
email: false
- stage: 'Lint markdown files'
- language: node_js
- node_js: 12
os: linux
+ language: generic
before_install: skip
install:
- npm i -g markdown-spellcheck