You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore: Fix package build scripts for git-deps and npm-link symlinks (#746)
## Background
This PR is copied from #481. It was contributed by @jasonkarns a couple of years ago. I just pulled his changes, merged master and resolved conflicts.
## Summary
Main change: `prepublishOnly` is the wrong lifecycle script for building/compiling. prepublishOnly does not run during install for git-deps; nor does it run when a package is being symlinked via npm-link. The correct script is `prepare`.
This PR:
- ensures the build/bundle/compile script is accurately defined as `build` so as to be run properly by the top level `lerna run build` script.
- ensures "clean" is run before building
- ensures `clean` is defined and exposed such that `lerna run clean` works properly
- ensures `build` is invoked during `prepare` lifecycle hook (packing, publishing, git-installing, npm-linking)
- preserves `npm test` being run during `prepublishOnly`
- adds package tarball pattern to gitignore so npm-pack can be run for inspection
- removes unnecessary files from `package.json#files` array (license, changelog, readme, and package.json files are included automatically)
- renames CHANGELOG.MD to be cased properly
## Test plan
No code changes
0 commit comments