Skip to content

Commit 9af51d8

Browse files
authored
refactor: Update datafile-manager to use Async Storage implementation from utils (#508)
Summary: React Native Async storage cache was moved to utils to make it available for other packages. This PR updates datafile manager to use the cache implementation from utils. Test plan: All tests pass
1 parent 02dcd72 commit 9af51d8

9 files changed

+8
-194
lines changed

packages/datafile-manager/__test__/httpPollingDatafileManager.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import HttpPollingDatafileManager from '../src/httpPollingDatafileManager';
1818
import { Headers, AbortableRequest, Response } from '../src/http';
1919
import { DatafileManagerConfig } from '../src/datafileManager';
2020
import { advanceTimersByTime, getTimerCount } from './testUtils';
21-
import PersistentKeyValueCache from '../src/persistentKeyValueCache';
21+
import { PersistentKeyValueCache } from '@optimizely/js-sdk-utils';
2222

2323
jest.mock('../src/backoffController', () => {
2424
return jest.fn().mockImplementation(() => {

packages/datafile-manager/__test__/reactNativeAsyncStorageCache.spec.ts

Lines changed: 0 additions & 70 deletions
This file was deleted.

packages/datafile-manager/package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/datafile-manager/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
},
4949
"dependencies": {
5050
"@optimizely/js-sdk-logging": "^0.1.0",
51-
"@optimizely/js-sdk-utils": "^0.2.0",
51+
"@optimizely/js-sdk-utils": "^0.3.2",
5252
"decompress-response": "^4.2.1"
5353
},
5454
"peerDependencies": {

packages/datafile-manager/src/datafileManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
import PersistentKeyValueCache from './persistentKeyValueCache';
16+
import { PersistentKeyValueCache } from '@optimizely/js-sdk-utils';
1717

1818
export interface DatafileUpdate {
1919
datafile: object;

packages/datafile-manager/src/httpPollingDatafileManager.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,12 @@
1515
*/
1616

1717
import { getLogger } from '@optimizely/js-sdk-logging';
18-
import { sprintf } from '@optimizely/js-sdk-utils';
18+
import { sprintf, PersistentKeyValueCache } from '@optimizely/js-sdk-utils';
1919
import { DatafileManager, DatafileManagerConfig, DatafileUpdate } from './datafileManager';
2020
import EventEmitter, { Disposer } from './eventEmitter';
2121
import { AbortableRequest, Response, Headers } from './http';
2222
import { DEFAULT_UPDATE_INTERVAL, MIN_UPDATE_INTERVAL, DEFAULT_URL_TEMPLATE } from './config';
2323
import BackoffController from './backoffController';
24-
import PersistentKeyValueCache from './persistentKeyValueCache';
2524

2625
const logger = getLogger('DatafileManager');
2726

packages/datafile-manager/src/persistentKeyValueCache.ts

Lines changed: 0 additions & 60 deletions
This file was deleted.

packages/datafile-manager/src/reactNativeAsyncStorageCache.ts

Lines changed: 0 additions & 55 deletions
This file was deleted.

packages/datafile-manager/src/reactNativeDatafileManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import { makeGetRequest } from './browserRequest';
1818
import HttpPollingDatafileManager from './httpPollingDatafileManager';
1919
import { Headers, AbortableRequest } from './http';
2020
import { DatafileManagerConfig } from './datafileManager';
21-
import ReactNativeAsyncStorageCache from './reactNativeAsyncStorageCache';
21+
import { ReactNativeAsyncStorageCache } from '@optimizely/js-sdk-utils';
2222

2323
export default class ReactNativeDatafileManager extends HttpPollingDatafileManager {
2424
protected makeGetRequest(reqUrl: string, headers: Headers): AbortableRequest {

0 commit comments

Comments
 (0)