Skip to content

Commit a8f783d

Browse files
committed
up
1 parent 40aafa7 commit a8f783d

4 files changed

+17
-353
lines changed

lib/odp/odp_manager.browser.ts

Lines changed: 0 additions & 201 deletions
This file was deleted.

lib/odp/odp_manager.node.ts

Lines changed: 0 additions & 144 deletions
This file was deleted.
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
import { describe, it, expect, beforeEach, vi } from 'vitest';
2+
3+
import { createOdpManager } from './odp_manager_factory.browser';
4+
import { getMockRequestHandler } from '../tests/mock/mock_request_handler';
5+
6+
describe('createOdpManager', () => {
7+
it('should use BrowserRequestHandler with the provided timeout as the segment request handler', () => {
8+
const odpManager = createOdpManager({ segmentsApiTimeout: 1000 });
9+
expect((odpManager as any).segmentRequestHandler.timeout).toBe(1000);
10+
});
11+
});

lib/odp/odp_manager_factory.browser.ts

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,13 @@ import { getOdpManager, OdpManagerOptions } from './odp_manager_factory';
66
export const BROWSER_DEFAULT_API_TIMEOUT = 10_000;
77

88
export const createOdpManager = (options: OdpManagerOptions): OdpManager => {
9-
let defaultRequestHandler = new BrowserRequestHandler({ timeout: BROWSER_DEFAULT_API_TIMEOUT });
10-
11-
const segmentRequestHandler = options.segmentsApiTimeout !== undefined ?
12-
new BrowserRequestHandler({ timeout: options.segmentsApiTimeout }) :
13-
defaultRequestHandler;
9+
const segmentRequestHandler = new BrowserRequestHandler({
10+
timeout: options.segmentsApiTimeout || BROWSER_DEFAULT_API_TIMEOUT,
11+
});
1412

15-
const eventRequestHandler = options.eventApiTimeout !== undefined ?
16-
new BrowserRequestHandler({ timeout: options.eventApiTimeout }) :
17-
defaultRequestHandler;
13+
const eventRequestHandler = new BrowserRequestHandler({
14+
timeout: options.eventApiTimeout || BROWSER_DEFAULT_API_TIMEOUT,
15+
});
1816

1917
return getOdpManager({
2018
...options,

0 commit comments

Comments
 (0)