test cases added

Author: uzair-folio3

packages/optimizely-sdk/lib/utils/semantic_version/index.tests.js

@@ -25,7 +25,12 @@ describe('lib/utils/sematic_version', function() {
           ['2.9.9-beta', '2.9.9-beta'],
           ['2.1', '2.1.0'],
           ['2', '2.12'],
-          ['2.9', '2.9.1']
+          ['2.9', '2.9.1'],
+          ['2.9+beta', '2.9+beta'],
+          ['2.9.9+beta', '2.9.9+beta'],
+          ['2.9.9+beta-alpha', '2.9.9+beta-alpha'],
+          ['2.2.3', '2.2.3+beta'],
+          ['2.1.3', '2.1.3-beta']
         ];
         for (const [targetVersion, userVersion] of versions) {
           const result = semanticVersion.compareVersion(targetVersion, userVersion)
@@ -45,7 +50,8 @@ describe('lib/utils/sematic_version', function() {
           ['3.7.0-prerelease+build', '3.7.0-prerelease+rc'],
           ['2.2.3-beta-beta1', '2.2.3-beta-beta2'],
           ['2.2.3-beta+beta1', '2.2.3-beta+beta2'],
-          ['2.2.3+beta2-beta1', '2.2.3+beta3-beta2']
+          ['2.2.3+beta2-beta1', '2.2.3+beta3-beta2'],
+          ['2.2.3+beta', '2.2.3']
         ];
         for (const [targetVersion, userVersion] of versions) {
           const result = semanticVersion.compareVersion(targetVersion, userVersion)
@@ -60,9 +66,8 @@ describe('lib/utils/sematic_version', function() {
           ['2.3', '2.0.1'],
           ['2.3.5', '2.3.1'],
           ['2.9.8', '2.9'],
+          ['3.1', '3'],
           ['2.1.2-release', '2.1.2-beta'],
-          ['2.1.3', '2.1.3-beta'],
-          ['2.1.3', '2.1.3+beta'],
           ['2.9.9+beta', '2.9.9-beta'],
           ['3.7.0+build3.7.0-prerelease+build', '3.7.0-prerelease'],
           ['2.1.3-beta-beta2', '2.1.3-beta'],

packages/optimizely-sdk/lib/utils/semantic_version/index.ts

@@ -173,8 +173,8 @@ const logger = getLogger();
       }
     }
 
-    // check if user version contains build or pre-release and target version doesn't
-    if ((isPreReleaseInuserProvidedVersion && !isPreReleaseInconditionsVersion) || (isBuildInuserProvidedVersion && !isBuildInconditionsVersion))
+    // check if user version contains release and target version contains build
+    if ((isPreReleaseInuserProvidedVersion && isBuildInconditionsVersion))
       return -1;
 
     return 0;