From d61c41ebc5387247310e3a4178738bb5594103d6 Mon Sep 17 00:00:00 2001 From: Yasir Ali Date: Tue, 18 Jul 2023 12:43:53 -0400 Subject: [PATCH 1/2] Implements a warning log for polling interval below 30s --- optimizely/config_manager.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/optimizely/config_manager.py b/optimizely/config_manager.py index 247f5ce5d..3a6102601 100644 --- a/optimizely/config_manager.py +++ b/optimizely/config_manager.py @@ -323,6 +323,11 @@ def set_update_interval(self, update_interval: Optional[int | float]) -> None: ) update_interval = enums.ConfigManager.DEFAULT_UPDATE_INTERVAL + if update_interval < 30: + self.logger.warning( + f'Polling intervals below 30 seconds are not recommended.' + ) + self.update_interval = update_interval def set_blocking_timeout(self, blocking_timeout: Optional[int | float]) -> None: From 5a3fd20fb68a5feefbd4833163eccd2ef28821e6 Mon Sep 17 00:00:00 2001 From: Yasir Ali Date: Tue, 18 Jul 2023 12:50:03 -0400 Subject: [PATCH 2/2] cleanup. --- optimizely/config_manager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/optimizely/config_manager.py b/optimizely/config_manager.py index 3a6102601..0e4008b7e 100644 --- a/optimizely/config_manager.py +++ b/optimizely/config_manager.py @@ -325,7 +325,7 @@ def set_update_interval(self, update_interval: Optional[int | float]) -> None: if update_interval < 30: self.logger.warning( - f'Polling intervals below 30 seconds are not recommended.' + 'Polling intervals below 30 seconds are not recommended.' ) self.update_interval = update_interval