fix: odp issues identified by fsc (#322)

* prevent errant identify calls

* select first odp integration in datafile

* capture uri scheme error

* fix validation when data is nil

Author: andrewleap-optimizely

lib/optimizely.rb

@@ -530,7 +530,7 @@ def is_feature_enabled(feature_flag_key, user_id, attributes = nil)
         return false
       end
 
-      user_context = create_user_context(user_id, attributes)
+      user_context = OptimizelyUserContext.new(self, user_id, attributes, identify: false)
       decision, = @decision_service.get_variation_for_feature(config, feature_flag, user_context)
 
       feature_enabled = false
@@ -770,7 +770,7 @@ def get_all_feature_variables(feature_flag_key, user_id, attributes = nil)
         return nil
       end
 
-      user_context = create_user_context(user_id, attributes)
+      user_context = OptimizelyUserContext.new(self, user_id, attributes, identify: false)
       decision, = @decision_service.get_variation_for_feature(config, feature_flag, user_context)
       variation = decision ? decision['variation'] : nil
       feature_enabled = variation ? variation['featureEnabled'] : false
@@ -931,7 +931,7 @@ def get_variation_with_config(experiment_key, user_id, attributes, config)
 
       return nil unless user_inputs_valid?(attributes)
 
-      user_context = create_user_context(user_id, attributes)
+      user_context = OptimizelyUserContext.new(self, user_id, attributes, identify: false)
       variation_id, = @decision_service.get_variation(config, experiment_id, user_context)
       variation = config.get_variation_from_id(experiment_key, variation_id) unless variation_id.nil?
       variation_key = variation['key'] if variation
@@ -998,7 +998,7 @@ def get_feature_variable_for_type(feature_flag_key, variable_key, variable_type,
         return nil
       end
 
-      user_context = create_user_context(user_id, attributes)
+      user_context = OptimizelyUserContext.new(self, user_id, attributes, identify: false)
       decision, = @decision_service.get_variation_for_feature(config, feature_flag, user_context)
       variation = decision ? decision['variation'] : nil
       feature_enabled = variation ? variation['featureEnabled'] : false

lib/optimizely/config/datafile_project_config.rb

@@ -93,7 +93,7 @@ def initialize(datafile, logger, error_handler)
       @experiment_key_map = generate_key_map(@experiments, 'key')
       @experiment_id_map = generate_key_map(@experiments, 'id')
       @audience_id_map = generate_key_map(@audiences, 'id')
-      @integration_key_map = generate_key_map(@integrations, 'key')
+      @integration_key_map = generate_key_map(@integrations, 'key', first_value: true)
       @audience_id_map = @audience_id_map.merge(generate_key_map(@typed_audiences, 'id')) unless @typed_audiences.empty?
       @variation_id_map = {}
       @variation_key_map = {}
@@ -525,15 +525,19 @@ def generate_feature_variation_map(feature_flags)
       flag_variation_map
     end
 
-    def generate_key_map(array, key)
+    def generate_key_map(array, key, first_value: false)
       # Helper method to generate map from key to hash in array of hashes
       #
       # array - Array consisting of hash
       # key - Key in each hash which will be key in the map
+      # first_value - Determines which value to save if there are duplicate keys. By default the last instance of the key
+      #               will be saved. Set to true to save the first key/value encountered.
       #
       # Returns map mapping key to hash
 
-      Hash[array.map { |obj| [obj[key], obj] }]
+      array
+        .group_by { |obj| obj[key] }
+        .transform_values { |group| first_value ? group.first : group.last }
     end
   end
 end

lib/optimizely/exceptions.rb

@@ -25,6 +25,13 @@ def initialize(msg = 'HTTP call resulted in a response with an error code.')
     end
   end
 
+  class HTTPUriError < Error
+    # Raised when a provided URI is invalid.
+    def initialize(msg = 'Provided URI was invalid.')
+      super
+    end
+  end
+
   class InvalidAudienceError < Error
     # Raised when an invalid audience is provided
 

lib/optimizely/helpers/http_utils.rb

@@ -17,6 +17,7 @@
 #
 
 require 'net/http'
+require_relative '../exceptions'
 
 module Optimizely
   module Helpers
@@ -28,6 +29,8 @@ def make_request(url, http_method, request_body = nil, headers = {}, read_timeou
         #
         uri = URI.parse(url)
 
+        raise HTTPUriError unless uri.respond_to?(:request_uri)
+
         case http_method
         when :get
           request = Net::HTTP::Get.new(uri.request_uri)

lib/optimizely/helpers/validator.rb

@@ -181,7 +181,7 @@ def finite_number?(value)
 
       def odp_data_types_valid?(data)
         valid_types = [String, Float, Integer, TrueClass, FalseClass, NilClass]
-        data.values.all? { |e| valid_types.member? e.class }
+        data&.values&.all? { |e| valid_types.member? e.class }
       end
 
       def segments_cache_valid?(segments_cache)

lib/optimizely/odp/odp_segment_api_manager.rb

@@ -17,6 +17,7 @@
 #
 
 require 'json'
+require_relative '../exceptions'
 
 module Optimizely
   class OdpSegmentApiManager
@@ -59,7 +60,7 @@ def fetch_segments(api_key, api_host, user_key, user_value, segments_to_check)
         @logger.log(Logger::DEBUG, "GraphQL download failed: #{e}")
         log_failure('network error')
         return nil
-      rescue Errno::EINVAL, Net::HTTPBadResponse, Net::HTTPHeaderSyntaxError => e
+      rescue Errno::EINVAL, Net::HTTPBadResponse, Net::HTTPHeaderSyntaxError, HTTPUriError => e
         log_failure(e)
         return nil
       end

lib/optimizely/optimizely_config.rb

@@ -201,7 +201,7 @@ def lookup_name_from_id(audience_id, audiences_map)
     def stringify_conditions(conditions, audiences_map)
       operand = 'OR'
       conditions_str = ''
-      length = conditions.length()
+      length = conditions.length
       return '' if length.zero?
       return "\"#{lookup_name_from_id(conditions[0], audiences_map)}\"" if length == 1 && !OPERATORS.include?(conditions[0])
 

spec/project_spec.rb

@@ -4659,5 +4659,25 @@ class InvalidEventManager; end # rubocop:disable Lint/ConstantDefinitionInBlock
       project.send_odp_event(type: 'wow', action: 'great', identifiers: {}, data: {'wow': {}})
       project.close
     end
+
+    it 'should not send odp events with legacy apis' do
+      experiment_key = 'experiment-segment'
+      feature_key = 'flag-segment'
+      user_id = 'test_user'
+
+      project = Optimizely::Project.new(config_body_integrations_JSON, nil, spy_logger)
+      allow(project.event_dispatcher).to receive(:dispatch_event).with(instance_of(Optimizely::Event))
+      expect(project.odp_manager).not_to receive(:send_event)
+
+      project.activate(experiment_key, user_id)
+      project.track('event1', user_id)
+      project.get_variation(experiment_key, user_id)
+      project.get_all_feature_variables(feature_key, user_id)
+      project.is_feature_enabled(feature_key, user_id)
+
+      expect(spy_logger).not_to have_received(:log).with(Logger::ERROR, anything)
+
+      project.close
+    end
   end
 end

spec/spec_params.rb

@@ -1321,7 +1321,13 @@ module OptimizelySpec
       }
     ],
     'accountId' => '10367498574',
-    'events' => [],
+    'events' => [
+      {
+        'experimentIds' => ['10420810910'],
+        'id' => '10404198134',
+        'key' => 'event1'
+      }
+    ],
     'revision' => '101'
   }.freeze