Review changes

Author: rashidsp

lib/optimizely/bucketer.rb

@@ -92,7 +92,12 @@ def bucket(experiment, bucketing_id, user_id)
       end
 
       # Handle the case when the traffic range is empty due to sticky bucketing
-      @config.logger.log(Logger::DEBUG, 'Bucketed into an empty traffic range. Returning nil.') if variation_id == ''
+      if variation_id == ''
+        @config.logger.log(
+          Logger::DEBUG,
+          'Bucketed into an empty traffic range. Returning nil.'
+        )
+      end
 
       @config.logger.log(Logger::INFO, "User '#{user_id}' is in no variation.")
       nil

lib/optimizely/project_config.rb

@@ -129,7 +129,9 @@ def initialize(datafile, logger, error_handler)
           variation_id = variation['id']
           variation['featureEnabled'] = variation['featureEnabled'] == true
           variation_variables = variation['variables']
-          @variation_id_to_variable_usage_map[variation_id] = generate_key_map(variation_variables, 'id') unless variation_variables.nil?
+          next if variation_variables.nil?
+
+          @variation_id_to_variable_usage_map[variation_id] = generate_key_map(variation_variables, 'id')
         end
         @variation_id_map[key] = generate_key_map(variations, 'id')
         @variation_key_map[key] = generate_key_map(variations, 'key')