Skip to content

Can't restart config manager after stopped #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasonkarns opened this issue Jan 24, 2020 · 3 comments · Fixed by #340
Closed

Can't restart config manager after stopped #237

jasonkarns opened this issue Jan 24, 2020 · 3 comments · Fixed by #340

Comments

@jasonkarns
Copy link
Contributor

The stop! method sets @stopped=true. So once the config manager is stopped (via stop!), it can never be started again.

if @stopped
@logger.log(Logger::WARN, 'Not starting. Already stopped.')
return
end

@mikeproeng37
Copy link
Contributor

@jasonkarns can you elaborate on the use case for this?

@jasonkarns
Copy link
Contributor Author

Tests; non-constant polling; local development; event-driven polling (polling is enabled upon receipt of an event, and turned off after a time-limit or successful update; then restarted upon receipt of another event).

Honestly, I'm more inclined to question the validity of an interface that includes start/stop methods that can't actually invoke them. (Order-dependent method invocation is horribly bad. The object should never be able to be put into an invalid state. If a "stopped" object can't be restarted, why not just destroy the object entirely?)

@Tamara-Barum
Copy link

Internal ticket created for review: FSSDK-9381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants