[GR-52169] Parfait findings in Windows native code.

PullRequest: graal/17236

Author: pejovica

substratevm/src/com.oracle.svm.native.jvm.windows/src/JvmFuncs.c

@@ -233,10 +233,15 @@ JNIEXPORT jobject JNICALL JVM_DoPrivileged(JNIEnv *env, jclass cls, jobject acti
             return (*env)->CallObjectMethod(env, action, run);
         }
     }
+
+    /* Some error occurred - clear pending exception and try to report the error. */
+    (*env)->ExceptionClear(env);
+
     errorClass = (*env)->FindClass(env, "java/lang/InternalError");
     if (errorClass != NULL && !(*env)->ExceptionCheck(env)) {
         (*env)->ThrowNew(env, errorClass, "Could not invoke PrivilegedAction");
     } else {
+        (*env)->ExceptionClear(env);
         (*env)->FatalError(env, "PrivilegedAction could not be invoked and the error could not be reported");
     }
     return NULL;

substratevm/src/com.oracle.svm.native.libchelper/src/getEnviron.c

@@ -33,6 +33,7 @@ char **getEnviron() {
 #else
 
 #include <windows.h>
+#include <stdio.h>
 
 static char **envptr = NULL; 
 static char *env = NULL;

substratevm/src/com.oracle.svm.native.libchelper/src/timeZone.c

@@ -34,6 +34,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 
+#define jio_fprintf fprintf
+
 #define VALUE_UNKNOWN           0
 #define VALUE_KEY               1
 #define VALUE_MAPID             2
@@ -107,7 +109,7 @@ getValueInRegistry(HKEY hKey,
 
     valSize = sizeof(val);
     ret = RegQueryValueExA(hKey, (char *) keyNames[keyIndex + 1], NULL,
-                           typePtr, val, &valSize);
+                           typePtr, (LPBYTE) val, &valSize);
     if (ret != ERROR_SUCCESS) {
         return ret;
     }
@@ -323,7 +325,7 @@ static int getWinTimeZone(char *winZoneName)
 
             size = sizeof(szValue);
             ret = getValueInRegistry(hSubKey, STD_NAME, &valueType,
-                                     szValue, &size);
+                                     (LPBYTE) szValue, &size);
             if (ret != ERROR_SUCCESS) {
                 /*
                  * NT 4.0 SP3 fails here since it doesn't have the "Std"