Skip to content

Commit 0e85385

Browse files
Quinn Tranjfvogel
authored andcommitted
scsi: qla2xxx: Fix stalled relogin
This patch sets and clears FCF_ASYNC_{SENT|ACTIVE} flags to prevent stalling of relogin attempt. Once flag are correctly set/cleared, relogin timer can retry relogin attempt for driver to continue login. Fixes: fa83e65 ("scsi: qla2xxx: ensure async flags are reset correctly") Cc: stable@vger.kernel.org #4.17 Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Orabug: 29411891 Signed-off-by: John Donnelly <John.P.Donnelly@oracle.com> Reviewed-by: Allen Pais <allen.pais@oracle.com>
1 parent c74c8f7 commit 0e85385

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

‎drivers/scsi/qla2xxx/qla_init.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ qla2x00_async_adisc_sp_done(void *ptr, int res)
437437
"Async done-%s res %x %8phC\n",
438438
sp->name, res, sp->fcport->port_name);
439439

440-
sp->fcport->flags &= ~FCF_ASYNC_SENT;
440+
sp->fcport->flags &= ~(FCF_ASYNC_SENT | FCF_ASYNC_ACTIVE);
441441

442442
memset(&ea, 0, sizeof(ea));
443443
ea.event = FCME_ADISC_DONE;

‎drivers/scsi/qla2xxx/qla_iocb.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2828,6 +2828,7 @@ qla24xx_els_dcmd2_iocb(scsi_qla_host_t *vha, int els_opcode,
28282828
ql_dbg(ql_dbg_io, vha, 0x3073,
28292829
"Enter: PLOGI portid=%06x\n", fcport->d_id.b24);
28302830

2831+
fcport->flags |= FCF_ASYNC_SENT;
28312832
sp->type = SRB_ELS_DCMD;
28322833
sp->name = "ELS_DCMD";
28332834
sp->fcport = fcport;

0 commit comments

Comments
 (0)