fbdev: omapfb: off by one in omapfb_register_client()

Dan Carpenter · gregkh · commit 3cfa558660f8 · 2018-09-26T08:38:01.000+02:00
[ Upstream commit 5ec1ec3 ] The omapfb_register_client[] array has OMAPFB_PLANE_NUM elements so the > should be >= or we are one element beyond the end of the array. Fixes: 8b08cf2 ("OMAP: add TI OMAP framebuffer driver") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: Imre Deak <imre.deak@solidboot.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
@@ -958,7 +958,7 @@ int omapfb_register_client(struct omapfb_notifier_block *omapfb_nb,
 {
 	int r;
 
-	if ((unsigned)omapfb_nb->plane_idx > OMAPFB_PLANE_NUM)
+	if ((unsigned)omapfb_nb->plane_idx >= OMAPFB_PLANE_NUM)
 		return -EINVAL;
 
 	if (!notifier_inited) {

Original file line number	Diff line number	Diff line change
`@@ -958,7 +958,7 @@ int omapfb_register_client(struct omapfb_notifier_block *omapfb_nb,`
`958`	`958`	`{`
`959`	`959`	`int r;`
`960`	`960`
`961`		`- if ((unsigned)omapfb_nb->plane_idx > OMAPFB_PLANE_NUM)`
	`961`	`+ if ((unsigned)omapfb_nb->plane_idx >= OMAPFB_PLANE_NUM)`
`962`	`962`	`return -EINVAL;`
`963`	`963`
`964`	`964`	`if (!notifier_inited) {`