Skip to content

Commit de76841

Browse files
StarryShadowZsuryasaimadhu
authored andcommitted
x86/mce/inject: Avoid out-of-bounds write when setting flags
A contrived zero-length write, for example, by using write(2): ... ret = write(fd, str, 0); ... to the "flags" file causes: BUG: KASAN: stack-out-of-bounds in flags_write Write of size 1 at addr ffff888019be7ddf by task writefile/3787 CPU: 4 PID: 3787 Comm: writefile Not tainted 5.16.0-rc7+ #12 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014 due to accessing buf one char before its start. Prevent such out-of-bounds access. [ bp: Productize into a proper patch. Link below is the next best thing because the original mail didn't get archived on lore. ] Fixes: 0451d14 ("EDAC, mce_amd_inj: Modify flags attribute to use string arguments") Signed-off-by: Zhang Zixun <[email protected]> Signed-off-by: Borislav Petkov <[email protected]> Link: https://lore.kernel.org/linux-edac/[email protected]/
1 parent 91f75eb commit de76841

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/x86/kernel/cpu/mce/inject.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ static ssize_t flags_write(struct file *filp, const char __user *ubuf,
363363
char buf[MAX_FLAG_OPT_SIZE], *__buf;
364364
int err;
365365

366-
if (cnt > MAX_FLAG_OPT_SIZE)
366+
if (!cnt || cnt > MAX_FLAG_OPT_SIZE)
367367
return -EINVAL;
368368

369369
if (copy_from_user(&buf, ubuf, cnt))

0 commit comments

Comments
 (0)