[GR-14806] Update specs

PullRequest: truffleruby/4551

Author: andrykonchin

spec/ruby/core/array/fetch_values_spec.rb

@@ -21,7 +21,7 @@
 
     describe "with unmatched indexes" do
       it "raises a index error if no block is provided" do
-        -> { @array.fetch_values(0, 1, 44) }.should raise_error(IndexError)
+        -> { @array.fetch_values(0, 1, 44) }.should raise_error(IndexError, "index 44 outside of array bounds: -3...3")
       end
 
       it "returns the default value from block" do
@@ -42,8 +42,14 @@
       @array.fetch_values(obj).should == [:c]
     end
 
+    it "does not support a Range object as argument" do
+      -> {
+        @array.fetch_values(1..2)
+      }.should raise_error(TypeError, "no implicit conversion of Range into Integer")
+    end
+
     it "raises a TypeError when the passed argument can't be coerced to Integer" do
-      -> { [].fetch_values("cat") }.should raise_error(TypeError)
+      -> { [].fetch_values("cat") }.should raise_error(TypeError, "no implicit conversion of String into Integer")
     end
   end
 end

spec/ruby/core/array/pack/a_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 require_relative '../fixtures/classes'
 require_relative 'shared/basic'

spec/ruby/core/array/pack/at_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 require_relative '../fixtures/classes'
 require_relative 'shared/basic'

spec/ruby/core/array/pack/b_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 require_relative '../fixtures/classes'
 require_relative 'shared/basic'

spec/ruby/core/array/pack/c_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 
 require_relative '../../../spec_helper'
 require_relative '../fixtures/classes'

spec/ruby/core/array/pack/comment_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 require_relative '../fixtures/classes'
 

spec/ruby/core/array/pack/h_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 require_relative '../fixtures/classes'
 require_relative 'shared/basic'

spec/ruby/core/array/pack/m_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 require_relative '../fixtures/classes'
 require_relative 'shared/basic'

spec/ruby/core/array/pack/shared/float.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 
 describe :array_pack_float_le, shared: true do
   it "encodes a positive Float" do

spec/ruby/core/array/pack/shared/integer.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 
 describe :array_pack_16bit_le, shared: true do
   it "encodes the least significant 16 bits of a positive number" do

spec/ruby/core/array/pack/shared/string.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 describe :array_pack_string, shared: true do
   it "adds count bytes of a String to the output" do
     ["abc"].pack(pack_format(2)).should == "ab"

spec/ruby/core/array/pack/u_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 require_relative '../fixtures/classes'
 require_relative 'shared/basic'

spec/ruby/core/array/pack/w_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 require_relative '../fixtures/classes'
 require_relative 'shared/basic'

spec/ruby/core/array/pack/x_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 require_relative '../fixtures/classes'
 require_relative 'shared/basic'

spec/ruby/core/array/pack/z_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 require_relative '../fixtures/classes'
 require_relative 'shared/basic'

spec/ruby/core/data/deconstruct_keys_spec.rb

@@ -1,10 +1,11 @@
 require_relative '../../spec_helper'
 require_relative 'fixtures/classes'
 
-describe "Data#deconstruct" do
+describe "Data#deconstruct_keys" do
   it "returns a hash of attributes" do
     klass = Data.define(:x, :y)
     d = klass.new(1, 2)
+
     d.deconstruct_keys([:x, :y]).should == {x: 1, y: 2}
   end
 
@@ -29,6 +30,7 @@
   it "accepts string attribute names" do
     klass = Data.define(:x, :y)
     d = klass.new(1, 2)
+
     d.deconstruct_keys(['x', 'y']).should == {'x' => 1, 'y' => 2}
   end
 
@@ -58,6 +60,7 @@
   it "returns an empty hash when there are more keys than attributes" do
     klass = Data.define(:x, :y)
     d = klass.new(1, 2)
+
     d.deconstruct_keys([:x, :y, :x]).should == {}
   end
 
@@ -84,6 +87,28 @@
     d.deconstruct_keys(nil).should == {x: 1, y: 2}
   end
 
+  it "tries to convert a key with #to_int if index is not a String nor a Symbol, but responds to #to_int" do
+    klass = Data.define(:x, :y)
+    d = klass.new(1, 2)
+
+    key = mock("to_int")
+    key.should_receive(:to_int).and_return(1)
+
+    d.deconstruct_keys([key]).should == { key => 2 }
+  end
+
+  it "raises a TypeError if the conversion with #to_int does not return an Integer" do
+    klass = Data.define(:x, :y)
+    d = klass.new(1, 2)
+
+    key = mock("to_int")
+    key.should_receive(:to_int).and_return("not an Integer")
+
+    -> {
+      d.deconstruct_keys([key])
+    }.should raise_error(TypeError, /can't convert MockObject to Integer/)
+  end
+
   it "raises TypeError if index is not a String, a Symbol and not convertible to Integer " do
     klass = Data.define(:x, :y)
     d = klass.new(1, 2)

spec/ruby/core/data/fixtures/classes.rb

@@ -9,5 +9,13 @@ def self.name
     end
 
     class DataSubclass < Data; end
+
+    MeasureSubclass = Class.new(Measure) do
+      def initialize(amount:, unit:)
+        super
+      end
+    end
+
+    Empty = Data.define()
   end
 end

spec/ruby/core/data/initialize_spec.rb

@@ -60,4 +60,15 @@
       e.message.should.include?("unknown keyword: :system")
     }
   end
+
+  it "supports super from a subclass" do
+    ms = DataSpecs::MeasureSubclass.new(amount: 1, unit: "km")
+
+    ms.amount.should == 1
+    ms.unit.should == "km"
+  end
+
+  it "supports Data with no fields" do
+    -> { DataSpecs::Empty.new }.should_not raise_error
+  end
 end

spec/ruby/core/encoding/compatible_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 
 require_relative '../../spec_helper'
 
@@ -171,7 +171,7 @@
 #     Use the following script to regenerate the matrix:
 #
 #     ```
-#       # -*- encoding: binary -*-
+#       # encoding: binary
 #
 #       ENCODINGS = [
 #         "US-ASCII",

spec/ruby/core/encoding/converter/convert_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 # frozen_string_literal: true
 require_relative '../../../spec_helper'
 

spec/ruby/core/encoding/converter/last_error_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 
 describe "Encoding::Converter#last_error" do

spec/ruby/core/encoding/converter/new_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 
 describe "Encoding::Converter.new" do

spec/ruby/core/encoding/converter/primitive_convert_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 # frozen_string_literal: false
 require_relative '../../../spec_helper'
 

spec/ruby/core/encoding/converter/primitive_errinfo_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 # frozen_string_literal: false
 require_relative '../../../spec_helper'
 

spec/ruby/core/encoding/converter/putback_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 
 describe "Encoding::Converter#putback" do

spec/ruby/core/encoding/fixtures/classes.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 module EncodingSpecs
   class UndefinedConversionError
     def self.exception

spec/ruby/core/encoding/invalid_byte_sequence_error/error_bytes_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative "../../../spec_helper"
 require_relative '../fixtures/classes'
 

spec/ruby/core/encoding/invalid_byte_sequence_error/incomplete_input_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../../spec_helper'
 
 describe "Encoding::InvalidByteSequenceError#incomplete_input?" do

spec/ruby/core/encoding/invalid_byte_sequence_error/readagain_bytes_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative "../../../spec_helper"
 require_relative '../fixtures/classes'
 

spec/ruby/core/encoding/replicate_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../spec_helper'
 
 describe "Encoding#replicate" do

spec/ruby/core/env/element_reference_spec.rb

@@ -1,4 +1,4 @@
-# -*- encoding: binary -*-
+# encoding: binary
 require_relative '../../spec_helper'
 require_relative 'fixtures/common'
 

spec/ruby/core/exception/frozen_error_spec.rb

@@ -28,7 +28,7 @@ def o.x; end
 
     -> {
       def object.x; end
-    }.should raise_error(FrozenError, "can't modify frozen object: #{object.to_s}")
+    }.should raise_error(FrozenError, "can't modify frozen object: #{object}")
 
     object = [].freeze
     -> { object << nil }.should raise_error(FrozenError, "can't modify frozen Array: []")

spec/ruby/core/exception/set_backtrace_spec.rb

@@ -1,13 +1,8 @@
 require_relative '../../spec_helper'
 require_relative 'fixtures/common'
+require_relative 'shared/set_backtrace'
 
 describe "Exception#set_backtrace" do
-  it "accepts an Array of Strings" do
-    err = RuntimeError.new
-    err.set_backtrace ["unhappy"]
-    err.backtrace.should == ["unhappy"]
-  end
-
   it "allows the user to set the backtrace from a rescued exception" do
     bt  = ExceptionSpecs::Backtrace.backtrace
     err = RuntimeError.new
@@ -20,65 +15,9 @@
     err.backtrace_locations.should == nil
   end
 
-  ruby_version_is "3.4" do
-    it "allows the user to set backtrace locations from a rescued exception" do
-      bt_locations = ExceptionSpecs::Backtrace.backtrace_locations
-      err = RuntimeError.new
-      err.backtrace.should == nil
-      err.backtrace_locations.should == nil
-
-      err.set_backtrace bt_locations
-
-      err.backtrace_locations.size.should == bt_locations.size
-      err.backtrace_locations.each_with_index do |loc, index|
-        other_loc = bt_locations[index]
-
-        loc.path.should == other_loc.path
-        loc.label.should == other_loc.label
-        loc.base_label.should == other_loc.base_label
-        loc.lineno.should == other_loc.lineno
-        loc.absolute_path.should == other_loc.absolute_path
-        loc.to_s.should == other_loc.to_s
-      end
-      err.backtrace.size.should == err.backtrace_locations.size
-    end
-  end
-
-  it "accepts an empty Array" do
-    err = RuntimeError.new
-    err.set_backtrace []
-    err.backtrace.should == []
-  end
-
-  it "accepts a String" do
+  it_behaves_like :exception_set_backtrace, -> backtrace {
     err = RuntimeError.new
-    err.set_backtrace "unhappy"
-    err.backtrace.should == ["unhappy"]
-  end
-
-  it "accepts nil" do
-    err = RuntimeError.new
-    err.set_backtrace nil
-    err.backtrace.should be_nil
-  end
-
-  it "raises a TypeError when passed a Symbol" do
-    err = RuntimeError.new
-    -> { err.set_backtrace :unhappy }.should raise_error(TypeError)
-  end
-
-  it "raises a TypeError when the Array contains a Symbol" do
-    err = RuntimeError.new
-    -> { err.set_backtrace ["String", :unhappy] }.should raise_error(TypeError)
-  end
-
-  it "raises a TypeError when the array contains nil" do
-    err = Exception.new
-    -> { err.set_backtrace ["String", nil] }.should raise_error(TypeError)
-  end
-
-  it "raises a TypeError when the argument is a nested array" do
-    err = Exception.new
-    -> { err.set_backtrace ["String", ["String"]] }.should raise_error(TypeError)
-  end
+    err.set_backtrace(backtrace)
+    err
+  }
 end