Improved pull request "Files Changed" experience feedback #163932
Replies: 2824 comments 1125 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Please add the ability to abandon a review in the new version of the UI as well. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Please add back the "Only Files Owned by You" filter. Without it, the new experience is frustrating when reviewing large PRs worked on by multiple teams. |
Beta Was this translation helpful? Give feedback.
-
|
My company has recently switched from Gitlab to GitHub and I am frankly shocked at how abysmal the PR review process is on here. In its current state, it is borderline unusable. The main problem is that it's almost impossible to address comments in a review that are asking for changes in a reliable way.
There are other issues, like the inability to create threads (that have to be resolved) with general comments not associated to a specific line of code. But just the two points mentioned above are so fundamentally important to a PR review process that they make reviewing PRs on this platform a huge pain. For an established platform like GitHub it should be absolutely unacceptable to have such a core feature (arguably the main reason to use a platform like this in the first place) not working properly. How are people even doing PR reviews with multiple cycles on here? |
Beta Was this translation helpful? Give feedback.
-
|
On Firefox in the new experience, I cannot copy suggested changes in a comment made by Copilot if I want to paste them somewhere else. This is possible in the older UI/UX. |
Beta Was this translation helpful? Give feedback.
-
|
I miss the ability to mark a file as viewed. Did we lose that or has it just been moved somewhere? |
Beta Was this translation helpful? Give feedback.
-
|
Why is there the |
Beta Was this translation helpful? Give feedback.
-
|
I added a one-line change suggestion in a comment without leaving a review, on a line that isn't currently changed in the pull request, and it renders as a suggestion to add the line where there was nothing there before. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
It's completely broken. The button at the top of my PR says 45 comments. I click to look at comments in the Panel. The first one has 3 replies that aren't showing in the panel so I click the replies button. Panel closes and the screen sometimes jumps to a place; whether it jumps or not, I don't see the comment. The originalbutton now says 59 comments. The feature has “AI ✨” all around it and its implementation with AI shows. I hate what this tech is doing to software. |
Beta Was this translation helpful? Give feedback.
-
|
I made a comment on a PR that shows up on the PR's main page (and in the Files Changed tab diff if I click on my avatar on the line I commented on), but doesn't show up in the new Files Changed tab Comments panel. It doesn't matter if I filter the comments there by author / whether they're outdated or resolved (the missing comment is neither). This is the reason why I had opted out of the new Files Changed view months ago, but it doesn't seem like I have that option anymore. The new Comments panel is un-useable. |
Beta Was this translation helpful? Give feedback.
-
|
For some reason I can't add a comment to a three-line section. If I click and drag the plus I can select a 2 line block or a 4 line block, no 3. Given the number of three-line statements out there (preamble, content, end; like an if statement) this is incredibly frustrating. |
Beta Was this translation helpful? Give feedback.
-
|
Suggestions are not visualized correctly, multi-line suggestions only show one line in the starting code Clicking on a filename in the menu on the left does not bring to a file if it's lower in the list |
Beta Was this translation helpful? Give feedback.
-
|
Searching the contents of the files in PR using native browser search doesn't work in big PR. It looks like that in a classic experience, all files and their contents were loaded and rendered on the page (except very long collapsed files like the package-lock.json). This allowed me to search for a variable or a function name across PR files to quickly find a referenced function. But now, due to the performance optimizations, files that are not visible in the currently viewed scroll region are not rendered and therefore not included when I search something. I suggest having internal search (triggered by something other than cmd+f to prevent highjacking default browser's search) that will search across current PR's files. Alternatively, clicking on a function name would reveal its references similarly to how it works when navigating files in a repo. |
Beta Was this translation helpful? Give feedback.
-
|
I still can’t check markdown checkboxes. This is a critical way we track required work for a pr.
|
Beta Was this translation helpful? Give feedback.
















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions