machine_hw_i2c_obj_t in Header? (esp32 port)

[cnadler86]

Is there a reason why the definition of the i2c type machine_hw_i2c_obj_t is in the c-file and not in the Header?

I would like to pass an i2c object to my Usermodule without mirroring the definition.

I can also PR this change.

[jonnor]

Hi @cnadler86. That struct appears to be ESP32 specific, and other port have other such structs. What is the thing you want to actually achieve?
There might not be a stable/portable C API for I2C objects - might be that the only stable way is to call via Python.

[cnadler86]

Hi @jonnor. Thx for your reply.
Basically what I want to do is assess the i2c objects structure definition in my user c module.
My actual approach is to "mirror" the structure definition in my module, what works, but is not very elegant, since I need to keep an eye on upcoming changes in the definition.

IMO, it would be better to migrate the machine_hw_i2c_obj_t struct definition to machine_i2c.h, so "everyone" could access it, but most of the ports (or perhaps all ports) don't define the structure in the header for i2c objects. So, probably it is wanted to have the i2c objects structure definition private.