Skip to content

Commit 6db7d49

Browse files
authored
chore(format): format module imports for readability (#1183)
1 parent 692345e commit 6db7d49

23 files changed

+177
-401
lines changed

git-cliff-core/src/changelog.rs

Lines changed: 13 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
1+
use std::collections::HashMap;
2+
use std::io::{Read, Write};
3+
use std::time::{SystemTime, UNIX_EPOCH};
4+
15
use crate::commit::Commit;
2-
use crate::config::{
3-
Config,
4-
GitConfig,
5-
};
6-
use crate::error::{
7-
Error,
8-
Result,
9-
};
10-
use crate::release::{
11-
Release,
12-
Releases,
13-
};
6+
use crate::config::{Config, GitConfig};
7+
use crate::error::{Error, Result};
8+
use crate::release::{Release, Releases};
149
#[cfg(feature = "bitbucket")]
1510
use crate::remote::bitbucket::BitbucketClient;
1611
#[cfg(feature = "gitea")]
@@ -20,15 +15,6 @@ use crate::remote::github::GitHubClient;
2015
#[cfg(feature = "gitlab")]
2116
use crate::remote::gitlab::GitLabClient;
2217
use crate::template::Template;
23-
use std::collections::HashMap;
24-
use std::io::{
25-
Read,
26-
Write,
27-
};
28-
use std::time::{
29-
SystemTime,
30-
UNIX_EPOCH,
31-
};
3218

3319
/// Changelog generator.
3420
#[derive(Debug)]
@@ -697,18 +683,15 @@ fn get_body_template(config: &Config, trim: bool) -> Result<Template> {
697683

698684
#[cfg(test)]
699685
mod test {
686+
use std::str;
687+
688+
use pretty_assertions::assert_eq;
689+
use regex::Regex;
690+
700691
use super::*;
701692
use crate::config::{
702-
Bump,
703-
ChangelogConfig,
704-
CommitParser,
705-
Remote,
706-
RemoteConfig,
707-
TextProcessor,
693+
Bump, ChangelogConfig, CommitParser, Remote, RemoteConfig, TextProcessor,
708694
};
709-
use pretty_assertions::assert_eq;
710-
use regex::Regex;
711-
use std::str;
712695

713696
fn get_test_data() -> (Config, Vec<Release<'static>>) {
714697
let config = Config {

git-cliff-core/src/command.rs

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,8 @@
1+
use std::io::{Error as IoError, Write};
2+
use std::process::{Command, Stdio};
3+
use std::{env, str, thread};
4+
15
use crate::error::Result;
2-
use std::io::{
3-
Error as IoError,
4-
Write,
5-
};
6-
use std::process::{
7-
Command,
8-
Stdio,
9-
};
10-
use std::thread;
11-
use std::{
12-
env,
13-
str,
14-
};
156

167
/// Runs the given OS command and returns the output as string.
178
///

git-cliff-core/src/commit.rs

Lines changed: 8 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,14 @@
1-
use crate::config::{
2-
CommitParser,
3-
GitConfig,
4-
LinkParser,
5-
TextProcessor,
6-
};
7-
use crate::error::{
8-
Error as AppError,
9-
Result,
10-
};
11-
use git_conventional::{
12-
Commit as ConventionalCommit,
13-
Footer as ConventionalFooter,
14-
};
1+
use git_conventional::{Commit as ConventionalCommit, Footer as ConventionalFooter};
152
#[cfg(feature = "repo")]
16-
use git2::{
17-
Commit as GitCommit,
18-
Signature as CommitSignature,
19-
};
20-
use lazy_regex::{
21-
Lazy,
22-
Regex,
23-
lazy_regex,
24-
};
25-
use serde::ser::{
26-
SerializeStruct,
27-
Serializer,
28-
};
29-
use serde::{
30-
Deserialize,
31-
Deserializer,
32-
Serialize,
33-
};
3+
use git2::{Commit as GitCommit, Signature as CommitSignature};
4+
use lazy_regex::{Lazy, Regex, lazy_regex};
5+
use serde::ser::{SerializeStruct, Serializer};
6+
use serde::{Deserialize, Deserializer, Serialize};
347
use serde_json::value::Value;
358

9+
use crate::config::{CommitParser, GitConfig, LinkParser, TextProcessor};
10+
use crate::error::{Error as AppError, Result};
11+
3612
/// Regular expression for matching SHA1 and a following commit message
3713
/// separated by a whitespace.
3814
static SHA1_REGEX: Lazy<Regex> = lazy_regex!(r#"^\b([a-f0-9]{40})\b (.*)$"#);

git-cliff-core/src/config.rs

Lines changed: 14 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,15 @@
1-
use crate::embed::EmbeddedConfig;
2-
use crate::error::Result;
3-
use crate::{
4-
command,
5-
error,
6-
};
1+
use std::path::{Path, PathBuf};
2+
use std::str::FromStr;
3+
use std::{fmt, fs};
4+
75
use glob::Pattern;
8-
use regex::{
9-
Regex,
10-
RegexBuilder,
11-
};
6+
use regex::{Regex, RegexBuilder};
127
use secrecy::SecretString;
13-
use serde::{
14-
Deserialize,
15-
Serialize,
16-
};
17-
use std::fs;
18-
use std::path::Path;
19-
use std::path::PathBuf;
20-
use std::{
21-
fmt,
22-
str::FromStr,
23-
};
8+
use serde::{Deserialize, Serialize};
9+
10+
use crate::embed::EmbeddedConfig;
11+
use crate::error::Result;
12+
use crate::{command, error};
2413

2514
/// Default initial tag.
2615
const DEFAULT_INITIAL_TAG: &str = "0.1.0";
@@ -525,9 +514,11 @@ impl FromStr for Config {
525514

526515
#[cfg(test)]
527516
mod test {
528-
use super::*;
529-
use pretty_assertions::assert_eq;
530517
use std::env;
518+
519+
use pretty_assertions::assert_eq;
520+
521+
use super::*;
531522
#[test]
532523
fn load() -> Result<()> {
533524
let path = PathBuf::from(env!("CARGO_MANIFEST_DIR"))

git-cliff-core/src/contributor.rs

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
1-
use serde::{
2-
Deserialize,
3-
Serialize,
4-
};
5-
use std::hash::{
6-
Hash,
7-
Hasher,
8-
};
1+
use std::hash::{Hash, Hasher};
2+
3+
use serde::{Deserialize, Serialize};
94

105
/// Representation of a remote contributor.
116
#[derive(Debug, Default, Clone, Eq, PartialEq, Deserialize, Serialize)]

git-cliff-core/src/embed.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
1-
use crate::config::Config;
2-
use crate::error::{
3-
Error,
4-
Result,
5-
};
6-
use rust_embed::RustEmbed;
71
use std::path::Path;
82
use std::str;
93

4+
use rust_embed::RustEmbed;
5+
6+
use crate::config::Config;
7+
use crate::error::{Error, Result};
8+
109
/// Default configuration file embedder/extractor.
1110
///
1211
/// Embeds `config/`[`DEFAULT_CONFIG`] into the binary.

git-cliff-core/src/error.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,9 @@ pub type Result<T> = core::result::Result<T, Error>;
125125

126126
#[cfg(test)]
127127
mod test {
128+
use git_conventional::{Commit, ErrorKind};
129+
128130
use super::*;
129-
use git_conventional::{
130-
Commit,
131-
ErrorKind,
132-
};
133131
fn mock_function() -> super::Result<Commit<'static>> {
134132
Ok(Commit::parse("test")?)
135133
}

git-cliff-core/src/release.rs

Lines changed: 15 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,18 @@
11
use std::collections::HashMap;
22

3-
use crate::commit::commits_to_conventional_commits;
3+
use next_version::{NextVersion, VersionUpdater};
4+
use semver::Version;
5+
use serde::{Deserialize, Serialize};
6+
use serde_json::value::Value;
7+
8+
use crate::commit::{Commit, Range, commits_to_conventional_commits};
9+
use crate::config::{Bump, BumpType};
410
use crate::error::Result;
5-
use crate::{
6-
commit::{
7-
Commit,
8-
Range,
9-
},
10-
config::Bump,
11-
config::BumpType,
12-
};
1311
#[cfg(feature = "remote")]
1412
use crate::{
1513
contributor::RemoteContributor,
16-
remote::{
17-
RemoteCommit,
18-
RemotePullRequest,
19-
RemoteReleaseMetadata,
20-
},
21-
};
22-
23-
use next_version::{
24-
NextVersion,
25-
VersionUpdater,
14+
remote::{RemoteCommit, RemotePullRequest, RemoteReleaseMetadata},
2615
};
27-
use semver::Version;
28-
use serde::{
29-
Deserialize,
30-
Serialize,
31-
};
32-
use serde_json::value::Value;
3316

3417
/// Representation of a release.
3518
#[derive(Default, Debug, Clone, PartialEq, Serialize, Deserialize)]
@@ -195,8 +178,9 @@ impl Releases<'_> {
195178

196179
#[cfg(test)]
197180
mod test {
198-
use super::*;
199181
use pretty_assertions::assert_eq;
182+
183+
use super::*;
200184
#[test]
201185
fn bump_version() -> Result<()> {
202186
fn build_release<'a>(version: &str, commits: &'a [&str]) -> Release<'a> {
@@ -392,12 +376,8 @@ mod test {
392376
#[test]
393377
fn update_github_metadata() -> Result<()> {
394378
use crate::remote::github::{
395-
GitHubCommit,
396-
GitHubCommitAuthor,
397-
GitHubCommitDetails,
398-
GitHubCommitDetailsAuthor,
399-
GitHubPullRequest,
400-
PullRequestLabel,
379+
GitHubCommit, GitHubCommitAuthor, GitHubCommitDetails,
380+
GitHubCommitDetailsAuthor, GitHubPullRequest, PullRequestLabel,
401381
};
402382

403383
let mut release = Release {
@@ -764,11 +744,7 @@ mod test {
764744
#[cfg(feature = "gitlab")]
765745
#[test]
766746
fn update_gitlab_metadata() -> Result<()> {
767-
use crate::remote::gitlab::{
768-
GitLabCommit,
769-
GitLabMergeRequest,
770-
GitLabUser,
771-
};
747+
use crate::remote::gitlab::{GitLabCommit, GitLabMergeRequest, GitLabUser};
772748

773749
let mut release = Release {
774750
version: None,
@@ -1156,10 +1132,7 @@ mod test {
11561132
#[test]
11571133
fn update_gitea_metadata() -> Result<()> {
11581134
use crate::remote::gitea::{
1159-
GiteaCommit,
1160-
GiteaCommitAuthor,
1161-
GiteaPullRequest,
1162-
PullRequestLabel,
1135+
GiteaCommit, GiteaCommitAuthor, GiteaPullRequest, PullRequestLabel,
11631136
};
11641137

11651138
let mut release = Release {
@@ -1516,9 +1489,7 @@ mod test {
15161489
#[test]
15171490
fn update_bitbucket_metadata() -> Result<()> {
15181491
use crate::remote::bitbucket::{
1519-
BitbucketCommit,
1520-
BitbucketCommitAuthor,
1521-
BitbucketPullRequest,
1492+
BitbucketCommit, BitbucketCommitAuthor, BitbucketPullRequest,
15221493
BitbucketPullRequestMergeCommit,
15231494
};
15241495

git-cliff-core/src/remote/bitbucket.rs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
1-
use crate::config::Remote;
2-
use crate::error::*;
31
use reqwest_middleware::ClientWithMiddleware;
4-
use serde::{
5-
Deserialize,
6-
Serialize,
7-
};
2+
use serde::{Deserialize, Serialize};
83

94
use super::*;
5+
use crate::config::Remote;
6+
use crate::error::*;
107

118
/// Log message to show while fetching data from Bitbucket.
129
pub const START_FETCHING_MSG: &str = "Retrieving data from Bitbucket...";
@@ -246,9 +243,10 @@ impl BitbucketClient {
246243

247244
#[cfg(test)]
248245
mod test {
246+
use pretty_assertions::assert_eq;
247+
249248
use super::*;
250249
use crate::remote::RemoteCommit;
251-
use pretty_assertions::assert_eq;
252250

253251
#[test]
254252
fn timestamp() {

git-cliff-core/src/remote/gitea.rs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
1-
use crate::config::Remote;
2-
use crate::error::*;
31
use reqwest_middleware::ClientWithMiddleware;
4-
use serde::{
5-
Deserialize,
6-
Serialize,
7-
};
2+
use serde::{Deserialize, Serialize};
83

94
use super::*;
5+
use crate::config::Remote;
6+
use crate::error::*;
107

118
/// Log message to show while fetching data from Gitea.
129
pub const START_FETCHING_MSG: &str = "Retrieving data from Gitea...";
@@ -205,9 +202,10 @@ impl GiteaClient {
205202

206203
#[cfg(test)]
207204
mod test {
205+
use pretty_assertions::assert_eq;
206+
208207
use super::*;
209208
use crate::remote::RemoteCommit;
210-
use pretty_assertions::assert_eq;
211209

212210
#[test]
213211
fn timestamp() {

0 commit comments

Comments
 (0)