Skip to content

Commit 1c1f8a3

Browse files
eisenhauervicentebolea
authored andcommitted
Kill hardcoded dir
1 parent b709ebd commit 1c1f8a3

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

.github/workflows/everything.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ jobs:
114114

115115
runs-on: ubuntu-20.04
116116
container:
117-
image: ghcr.io/ornladios/adios2:ci-tmp-spack-ubuntu20.04-${{ matrix.compiler }}
117+
image: ghcr.io/ornladios/adios2:ci-tmp-spack-${{ matrix.os }}-${{ matrix.compiler }}
118118
options: --shm-size=1g
119119
env:
120120
GH_YML_JOBNAME: ${{ matrix.os }}-${{ matrix.compiler }}${{ matrix.shared == 'static' && '-static' || ''}}-${{ matrix.parallel }}

scripts/ci/images/Dockerfile.ci-spack-ubuntu20.04-base

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ ARG E4S_VERSION=23.08
66
ARG ENABLED_ENVS="serial,ompi,mpich"
77
ARG EXTERNAL_PACKAGES
88
ARG EXTRA_VARIANTS
9+
ARG PATCH_VARIANT_XROOTD
910

1011

1112
# Clone and patch spack
@@ -24,11 +25,10 @@ COPY packages.yaml /etc/spack/packages.yaml
2425
WORKDIR /spack
2526
# TODO: Patch only needed until we merge https://github.com/spack/spack/pull/40964
2627
RUN if [ ${E4S_VERSION%.*} -le 23 ]; then git apply 0001-mpich-support-ch3-sock.patch; fi
27-
28+
RUN if [ -n "${PATCH_VARIANT_XROOTD}" ]; then git apply 0002-adios2-add-xrootd-variant.patch; fi
2829
# Install base specs
2930
RUN . /spack/share/spack/setup-env.sh && \
3031
if test -n "${EXTERNAL_PACKAGES}"; then spack external find ${EXTERNAL_PACKAGES}; fi && \
31-
git apply 0002-adios2-add-xrootd-variant.patch && \
3232
spack mirror add E4S "https://cache.e4s.io/${E4S_VERSION}" && \
3333
export ADIOS_SPEC_NO_MPI="adios2~mpi${EXTRA_VARIANTS}" && \
3434
export ADIOS_SPEC_OPENMPI="adios2+mpi${EXTRA_VARIANTS} ^openmpi" && \

scripts/ci/images/build-ubuntu.sh

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33
set -ex
44

55
# Build the base image
6-
docker build --progress=plain --build-arg EXTRA_VARIANTS="+blosc+ssc ^mgard@2023-01-10" --rm -f ./Dockerfile.ci-spack-ubuntu20.04-base -t ghcr.io/ornladios/adios2:ci-tmp-spack-ubuntu20.04-base .
6+
docker build --progress=plain \
7+
--build-arg EXTRA_VARIANTS="+blosc+ssc ^mgard@2023-01-10" \
8+
--build-arg PATCH_VARIANT_XROOTD=ON \
9+
--rm -f ./Dockerfile.ci-spack-ubuntu20.04-base \
10+
-t ghcr.io/ornladios/adios2:ci-tmp-spack-ubuntu20.04-base \
11+
.
712

813
# Build the gcc8, gcc9, and gcc10 images
914
docker build --rm --build-arg GCC_VERSION=8 -f ./Dockerfile.ci-spack-ubuntu20.04-gcc -t ghcr.io/ornladios/adios2:ci-tmp-spack-ubuntu20.04-gcc8 .
@@ -22,15 +27,14 @@ docker build \
2227
--build-arg E4S_VERSION="24.05" \
2328
--build-arg EXTRA_VARIANTS="+blosc2" \
2429
-f ./Dockerfile.ci-spack-ubuntu20.04-base \
25-
-t ghcr.io/ornladios/adios2:ci-spack-ubuntu22.04-gcc11 \
30+
-t ghcr.io/ornladios/adios2:ci-tmp-spack-ubuntu22.04-gcc11 \
2631
.
2732

2833
# Push images to github container registry
2934
docker push ghcr.io/ornladios/adios2:ci-tmp-spack-ubuntu20.04-base
3035
docker push ghcr.io/ornladios/adios2:ci-tmp-spack-ubuntu20.04-gcc8
3136
docker push ghcr.io/ornladios/adios2:ci-tmp-spack-ubuntu20.04-gcc9
3237
docker push ghcr.io/ornladios/adios2:ci-tmp-spack-ubuntu20.04-gcc10
33-
docker push ghcr.io/ornladios/adios2:ci-tmp-spack-ubuntu20.04-gcc11
3438
docker push ghcr.io/ornladios/adios2:ci-tmp-spack-ubuntu20.04-clang6
3539
docker push ghcr.io/ornladios/adios2:ci-tmp-spack-ubuntu20.04-clang10
36-
40+
docker push ghcr.io/ornladios/adios2:ci-tmp-spack-ubuntu22.04-gcc11

testing/adios2/engine/bp/generateXRootDConfig.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ mkdir -p xroot/etc/xrootd
66
{
77
echo "xrootd.fslib libXrdSsi.so";
88
echo ""
9-
echo "all.export /home/eisen/xroot/data nolock r/w";
9+
echo "all.export ${PWD}/xroot/data nolock r/w";
1010
echo ""
1111
echo "oss.statlib -2 libXrdSsi.so";
1212
echo ""

0 commit comments

Comments
 (0)