Add testing for negative values

Author: anagainaru

testing/adios2/derived/TestBPDerivedCorrectness.cpp

@@ -25,13 +25,22 @@ class DerivedCorrectnessP : public DerivedCorrectness,
     adios2::DerivedVarType GetThreads() { return GetParam(); };
 };
 
-TEST_P(DerivedCorrectnessP, BasicCorrectnessTest)
+TEST_P(DerivedCorrectnessP, ErrorTest)
 {
     adios2::DerivedVarType mode = GetParam();
     adios2::ADIOS adios;
-    adios2::IO bpOut = adios.DeclareIO("BPNoData");
+    adios2::IO bpOut = adios.DeclareIO("BPDerivedError");
+    EXPECT_THROW(bpOut.DefineDerivedVariable("derived", "x= var1 \n nofunction(x)", mode),
+                 std::invalid_argument);
     EXPECT_THROW(bpOut.DefineDerivedVariable("derived", "x= var1 \n sqrt(x)", mode),
                  std::invalid_argument);
+}
+
+TEST_P(DerivedCorrectnessP, BasicCorrectnessTest)
+{
+    adios2::DerivedVarType mode = GetParam();
+    adios2::ADIOS adios;
+    adios2::IO bpOut = adios.DeclareIO("BPNoData");
 
     const size_t N = 10;
     std::default_random_engine generator;

testing/adios2/derived/TestBPDerivedCorrectnessMPI.cpp

@@ -90,7 +90,7 @@ TEST_P(DerivedCorrectnessMPIP, ScalarFunctionsCorrectnessTest)
                                     mode);
         bpOut.DefineDerivedVariable(derConstAdd,
                                     "x =" + varname[0] + " \n"
-                                    "add(x, 4, 1)",
+                                    "add(x, 6, -1)",
                                     mode);
         bpOut.DefineDerivedVariable(derSubtrName,
                                     "x =" + varname[0] + " \n"
@@ -106,7 +106,7 @@ TEST_P(DerivedCorrectnessMPIP, ScalarFunctionsCorrectnessTest)
                                     mode);
         bpOut.DefineDerivedVariable(derConstMult,
                                     "x =" + varname[0] + " \n"
-                                    "multiply(x, 5, 2)",
+                                    "multiply(x, 5, -2)",
                                     mode);
         bpOut.DefineDerivedVariable(derDivName,
                                     "x =" + varname[0] + " \n"
@@ -198,7 +198,7 @@ TEST_P(DerivedCorrectnessMPIP, ScalarFunctionsCorrectnessTest)
             calcFloat = readUx[ind] * readUy[ind] * readUz[ind];
             EXPECT_TRUE(fabs(calcFloat - readMult[ind]) < epsilon);
 
-            calcFloat = readUx[ind] * 10;
+            calcFloat = readUx[ind] * (-10);
             EXPECT_TRUE(fabs(calcFloat - readConstMult[ind]) < epsilon);
 
             calcFloat = readUx[ind] / readUy[ind] / readUz[ind];