Update to internal_publish_base_url

Author: azeemshaikh38

action.yaml

@@ -37,7 +37,7 @@ inputs:
     required: false
     default: false
 
-  publish_base_url:
+  internal_publish_base_url:
     description: "INPUT: Base URL for publishing results. Used for testing."
     required: false
     default: "https://api.securityscorecards.dev"

options/env.go

@@ -38,12 +38,12 @@ const (
 
 	// TODO(input): INPUT_ constants should be removed in a future release once
 	//              they have replacements in upstream scorecard.
-	EnvInputRepoToken         = "INPUT_REPO_TOKEN"             //nolint:gosec
-	EnvInputInternalRepoToken = "INPUT_INTERNAL_DEFAULT_TOKEN" //nolint:gosec
-	EnvInputResultsFile       = "INPUT_RESULTS_FILE"
-	EnvInputResultsFormat     = "INPUT_RESULTS_FORMAT"
-	EnvInputPublishResults    = "INPUT_PUBLISH_RESULTS"
-	EnvInputPublishBaseURL    = "INPUT_PUBLISH_BASE_URL"
+	EnvInputRepoToken              = "INPUT_REPO_TOKEN"             //nolint:gosec
+	EnvInputInternalRepoToken      = "INPUT_INTERNAL_DEFAULT_TOKEN" //nolint:gosec
+	EnvInputResultsFile            = "INPUT_RESULTS_FILE"
+	EnvInputResultsFormat          = "INPUT_RESULTS_FORMAT"
+	EnvInputPublishResults         = "INPUT_PUBLISH_RESULTS"
+	EnvInputInternalPublishBaseURL = "INPUT_INTERNAL_PUBLISH_BASE_URL"
 )
 
 // Errors

signing/signing.go

@@ -106,7 +106,7 @@ func ProcessSignature(jsonPayload []byte, repoName, repoRef, accessToken string)
 
 	// Call scorecard-webapp-api to process and upload signature.
 	// Setup HTTP request and context.
-	apiURL := os.Getenv(options.EnvInputPublishBaseURL)
+	apiURL := os.Getenv(options.EnvInputInternalPublishBaseURL)
 	rawURL := fmt.Sprintf("%s/projects/github.com/%s", apiURL, repoName)
 	parsedURL, err := url.Parse(rawURL)
 	if err != nil {

signing/signing_test.go

@@ -19,6 +19,8 @@ package signing
 import (
 	"os"
 	"testing"
+
+	"github.com/ossf/scorecard-action/options"
 )
 
 // TODO: For this test to work, fake the OIDC token retrieval with something like.
@@ -80,7 +82,7 @@ func Test_ProcessSignature(t *testing.T) {
 	repoName := "ossf-tests/scorecard-action"
 	repoRef := "refs/heads/main"
 	accessToken := os.Getenv("GITHUB_AUTH_TOKEN")
-	os.Setenv("INPUT_PUBLISH_BASE_URL", "https://api.securityscorecards.dev")
+	os.Setenv(options.EnvInputInternalPublishBaseURL, "https://api.securityscorecards.dev")
 
 	if err != nil {
 		t.Errorf("Error reading testdata:, %v", err)