Skip to content

Commit 88d5218

Browse files
committed
Use release tag name instead of name in log messages
Use the release TagName instead of Name when reporting found releases. An example of the problem using Name: $ go run . --repo=github.com/magefile/mage --show-details --checks=Signed-Releases Starting [Signed-Releases] Finished [Signed-Releases] RESULTS ------- Signed-Releases: Fail 10 release found: Colors, working directory, some better errors !! release Colors, working directory, some better errors has no signed artifacts release found: Modules and go1.13 Fixes !! release Modules and go1.13 Fixes has no signed artifacts release found: v1.8.0 - Papercuts and Bug Fixes !! release v1.8.0 - Papercuts and Bug Fixes has no signed artifacts release found: v1.7.1 !! release v1.7.1 has no signed artifacts release found: v1.7.0 Mage Imports !! release v1.7.0 Mage Imports has no signed artifacts release found: v1.6.2 Bug Fixes !! release v1.6.2 Bug Fixes has no signed artifacts found signed artifacts for 0 out of 6 releases With this commit: Signed-Releases: Fail 10 release found: v1.10.0 !! release v1.10.0 has no signed artifacts release found: v1.9.0 !! release v1.9.0 has no signed artifacts release found: v1.8.0 !! release v1.8.0 has no signed artifacts release found: v1.7.1 !! release v1.7.1 has no signed artifacts release found: v1.7.0 !! release v1.7.0 has no signed artifacts release found: v1.6.2 !! release v1.6.2 has no signed artifacts found signed artifacts for 0 out of 6 releases
1 parent a239820 commit 88d5218

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

checks/signed_releases.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func SignedReleases(c checker.Checker) checker.CheckResult {
4545
if len(assets) == 0 {
4646
continue
4747
}
48-
c.Logf("release found: %s", r.GetName())
48+
c.Logf("release found: %s", r.GetTagName())
4949
totalReleases++
5050
signed := false
5151
for _, asset := range assets {
@@ -62,7 +62,7 @@ func SignedReleases(c checker.Checker) checker.CheckResult {
6262
}
6363
}
6464
if !signed {
65-
c.Logf("!! release %s has no signed artifacts", r.GetName())
65+
c.Logf("!! release %s has no signed artifacts", r.GetTagName())
6666
}
6767
if totalReleases > releaseLookBack {
6868
break

0 commit comments

Comments
 (0)