Implement sonarcloud suggestions

eduar-hte · eduar-hte · commit 869e36952538 · 2024-04-28T18:42:58.000-03:00
diff --git a/examples/reading_logs_via_rule_message/reading_logs_via_rule_message.h b/examples/reading_logs_via_rule_message/reading_logs_via_rule_message.h
@@ -124,7 +124,7 @@ class ReadingLogsViaRuleMessage {
             m_rules(rules)
         { }
 
-    int process() {
+    int process() const {
         pthread_t threads[NUM_THREADS];
         int i;
         struct data_ms dms;
diff --git a/src/rule_with_operator.cc b/src/rule_with_operator.cc
@@ -133,7 +133,7 @@ bool RuleWithOperator::executeOperatorAt(Transaction *trans, const std::string &
 
 void RuleWithOperator::getVariablesExceptions(Transaction *t,
     variables::Variables *exclusion, variables::Variables *addition) {
-    for (auto &a : t->m_rules->m_exceptions.m_variable_update_target_by_tag) { // cppcheck-suppress ctunullpointer
+    for (const auto &a : t->m_rules->m_exceptions.m_variable_update_target_by_tag) { // cppcheck-suppress ctunullpointer
         if (containsTag(*a.first.get(), t) == false) {
             continue;
         }

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ bool RuleWithOperator::executeOperatorAt(Transaction *trans, const std::string &`
`133`	`133`
`134`	`134`	`void RuleWithOperator::getVariablesExceptions(Transaction *t,`
`135`	`135`	`variables::Variables exclusion, variables::Variables addition) {`
`136`		`- for (auto &a : t->m_rules->m_exceptions.m_variable_update_target_by_tag) { // cppcheck-suppress ctunullpointer`
	`136`	`+ for (const auto &a : t->m_rules->m_exceptions.m_variable_update_target_by_tag) { // cppcheck-suppress ctunullpointer`
`137`	`137`	`if (containsTag(*a.first.get(), t) == false) {`
`138`	`138`	`continue;`
`139`	`139`	`}`