Skip to content

Commit 9cb95a8

Browse files
committed
revert(no-unnecessary-type-arguments): drop inference reporting (#892)
Align with typescript-eslint/typescript-eslint#12199 by reverting the #853 port of inferred-type reporting. Keep the later default-type equivalence fix from #862. Validation: - go test ./internal/rules/no_unnecessary_type_arguments/... - cd e2e && pnpm test --run snapshot.test.ts fixes oxc-project/oxc#21464 fixes #875 fixes oxc-project/oxc#21096 fises oxc-project/oxc#20933
1 parent f1049e4 commit 9cb95a8

File tree

4 files changed

+311
-826
lines changed

4 files changed

+311
-826
lines changed

e2e/__snapshots__/snapshot.test.ts.snap

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1382,28 +1382,6 @@ exports[`TSGoLint E2E Snapshot Tests > should generate consistent diagnostics sn
13821382
},
13831383
"rule": "no-unnecessary-template-expression",
13841384
},
1385-
{
1386-
"file_path": "fixtures/basic/rules/no-unnecessary-type-arguments/index.ts",
1387-
"fixes": [
1388-
{
1389-
"range": {
1390-
"end": 214,
1391-
"pos": 206,
1392-
},
1393-
"text": "",
1394-
},
1395-
],
1396-
"kind": 0,
1397-
"message": {
1398-
"description": "This value can be trivially inferred for this type parameter, so it can be omitted.",
1399-
"id": "canBeInferred",
1400-
},
1401-
"range": {
1402-
"end": 213,
1403-
"pos": 207,
1404-
},
1405-
"rule": "no-unnecessary-type-arguments",
1406-
},
14071385
{
14081386
"file_path": "fixtures/basic/rules/no-unnecessary-type-arguments/index.ts",
14091387
"fixes": [
@@ -1418,7 +1396,7 @@ exports[`TSGoLint E2E Snapshot Tests > should generate consistent diagnostics sn
14181396
"kind": 0,
14191397
"message": {
14201398
"description": "This is the default value for this type parameter, so it can be omitted.",
1421-
"id": "isDefaultParameterValue",
1399+
"id": "unnecessaryTypeParameter",
14221400
},
14231401
"range": {
14241402
"end": 213,

0 commit comments

Comments
 (0)