fix(prefer-optional-chain): ignore non-access OR comparison (#872)

fixes oxc-project/oxc#21077

Author: camc314

internal/rules/prefer_optional_chain/prefer_optional_chain.go

@@ -1589,8 +1589,16 @@ outer3:
 		}
 
 		comparedExpr := left
+		hasPropertyAccess := leftIsAccess
 		if rightIsAccess {
 			comparedExpr = right
+			hasPropertyAccess = true
+		}
+		// OR chains can only safely extend through comparisons that actually inspect
+		// an access expression. Non-nullish identifier comparisons like `b === a`
+		// should not seed an optional-chain candidate such as `b === a || b.foo()`.
+		if !hasPropertyAccess {
+			return Operand{typ: OperandTypeInvalid, node: node}
 		}
 		return Operand{typ: OperandTypeComparison, node: node, comparedExpr: comparedExpr}
 	}

internal/rules/prefer_optional_chain/prefer_optional_chain_test.go

@@ -1000,6 +1000,14 @@ func TestPreferOptionalChainRule(t *testing.T) {
 
 			left !== shared.name && right.prop === shared.name;
 		`},
+		{
+			Code: `const a: string | null = '';
+const b: string = '';
+
+if (!a || b === a || b.indexOf('input, button, a')) {
+  console.log('Hello, World');
+}`,
+		},
 	}
 
 	invalidCases := []rule_tester.InvalidTestCase{