msw endpoint for get rules

Author: david-crespo

app/pages/project/networking/VpcPage/modals/firewall-rules.tsx

@@ -33,7 +33,7 @@ const CommonForm = ({ id, error }: FormProps) => (
     <SideModal.Section>
       <div className="space-y-0.5">
         <FieldTitle htmlFor="priority">Priority</FieldTitle>
-        <TextFieldHint id="priority-hint">Must be 0&ndash;35535</TextFieldHint>
+        <TextFieldHint id="priority-hint">Must be 0&ndash;65535</TextFieldHint>
         <NumberTextField
           id="priority"
           name="priority"
@@ -297,7 +297,7 @@ export function CreateFirewallRuleModal({
           priority: Yup.number()
             .integer()
             .min(0)
-            .max(35535)
+            .max(65535)
             .required('Required'),
         })}
         validateOnBlur

libs/api-mocks/msw/db.ts

@@ -131,6 +131,7 @@ const initDb = {
   disks: [mock.disk],
   vpcs: [mock.vpc],
   vpcSubnets: [mock.vpcSubnet],
+  vpcFirewallRules: [...mock.defaultFirewallRules],
 }
 
 const clone = (o: unknown) => JSON.parse(JSON.stringify(o))

libs/api-mocks/msw/handlers.ts

@@ -311,4 +311,15 @@ export const handlers = [
       return res(ctx.status(204))
     }
   ),
+
+  rest.get<never, VpcParams, Json<Api.VpcFirewallRuleResultsPage> | GetErr>(
+    '/api/organizations/:orgName/projects/:projectName/vpcs/:vpcName/firewall/rules',
+    (req, res, ctx) => {
+      const vpc = lookupVpc(req, res, ctx)
+      if (vpc.err) return vpc.err
+      // TODO: uncomment once omicron PR lands
+      const items = db.vpcFirewallRules //.filter((r) => r.vpc_id === vpc.ok.id)
+      return res(json({ items }))
+    }
+  ),
 ]

libs/api-mocks/vpc.ts

@@ -2,20 +2,24 @@ import type { Json } from './json-type'
 import { project } from './project'
 import type {
   Vpc,
+  VpcFirewallRule,
   VpcResultsPage,
   VpcSubnet,
   VpcSubnetResultsPage,
 } from '@oxide/api'
 
+const time_created = new Date(2021, 0, 1).toISOString()
+const time_modified = new Date(2021, 0, 2).toISOString()
+
 export const vpc: Json<Vpc> = {
   id: 'vpc-id',
   name: 'mock-vpc',
   description: 'a fake vpc',
   dns_name: 'mock-vpc',
-  time_created: new Date(2021, 0, 1).toISOString(),
-  time_modified: new Date(2021, 0, 2).toISOString(),
   project_id: project.id,
   system_router_id: 'router-id', // ???
+  time_created,
+  time_modified,
 }
 
 export const vpcs: Json<VpcResultsPage> = { items: [vpc] }
@@ -43,3 +47,74 @@ export const vpcSubnet2: Json<VpcSubnet> = {
 export const vpcSubnets: Json<VpcSubnetResultsPage> = {
   items: [vpcSubnet],
 }
+
+// TODO: uncomment vpc_ids once omicron PR lands
+export const defaultFirewallRules: Json<VpcFirewallRule>[] = [
+  {
+    id: 'firewall-rule-id-1',
+    name: 'allow-internal-inbound',
+    status: 'enabled',
+    direction: 'inbound',
+    targets: [{ type: 'vpc', value: 'default' }],
+    action: 'allow',
+    description:
+      'allow inbound traffic to all instances within the VPC if originated within the VPC',
+    filters: {
+      hosts: [{ type: 'vpc', value: 'default' }],
+    },
+    priority: 65534,
+    time_created,
+    time_modified,
+    // vpc_id: vpc.id,
+  },
+  {
+    id: 'firewall-rule-id-2',
+    name: 'allow-ssh',
+    status: 'enabled',
+    direction: 'inbound',
+    targets: [{ type: 'vpc', value: 'default' }],
+    description: 'allow inbound TCP connections on port 22 from anywhere',
+    filters: {
+      ports: ['22'],
+      protocols: ['TCP'],
+    },
+    action: 'allow',
+    priority: 65534,
+    time_created,
+    time_modified,
+    // vpc_id: vpc.id,
+  },
+  {
+    id: 'firewall-rule-id-3',
+    name: 'allow-icmp',
+    status: 'enabled',
+    direction: 'inbound',
+    targets: [{ type: 'vpc', value: 'default' }],
+    description: 'allow inbound ICMP traffic from anywhere',
+    filters: {
+      protocols: ['ICMP'],
+    },
+    action: 'allow',
+    priority: 65534,
+    time_created,
+    time_modified,
+    // vpc_id: vpc.id,
+  },
+  {
+    id: 'firewall-rule-id-4',
+    name: 'allow-rdp',
+    status: 'enabled',
+    direction: 'inbound',
+    targets: [{ type: 'vpc', value: 'default' }],
+    description: 'allow inbound TCP connections on port 3389 from anywhere',
+    filters: {
+      ports: ['3389'],
+      protocols: ['TCP'],
+    },
+    action: 'allow',
+    priority: 65534,
+    time_created,
+    time_modified,
+    // vpc_id: vpc.id,
+  },
+]