-
Notifications
You must be signed in to change notification settings - Fork 14
Automatic ACS URL in IdP forms w/ copy button #2510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
fe899c6
Add copyable prop to input; set up automatic ACS URL
charliepark 46720b8
unnecessary comment
charliepark 5aaa096
Add tooltip when value is too long to see
charliepark 08a53e3
No need for useEffect
charliepark 2e7b1f1
Revert to useEffect; add tests for getSubdomain
charliepark c262d3c
Merge branch 'main' into automatic_acs_url
charliepark e1c7d5f
Update design of copyable input
charliepark 1cfbeae
Remove right padding for copyable text
charliepark f894637
full-height button
charliepark 158c456
slightly wider
charliepark 32b2ab4
Combobox border tweaks
charliepark 37f8317
slightly taller Listbox to match other inputs
charliepark 771e164
shuffle files around, make helper not depend on window
david-crespo d1120a3
constrain TextInput value to be a string
david-crespo f07b3fa
test IdP create and edit
david-crespo c877eaf
Merge branch 'main' into automatic_acs_url
david-crespo 31abe74
Merge main and resolve conflict
charliepark 78730ca
Add checkbox to allow user to use custom ACS URL
charliepark 0e14c73
Update test to handle unchecking/rechecking standard ACS URL
charliepark c10403d
Update microcopy
charliepark 8112dce
use regular useState instead of form for the checkbox
david-crespo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.