You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is slightly more complex than just updating the dependencies, but not by much.
There are two distinct parts to this work:
pull in updated Attest trait w/ new async impls
account for type renames & repo reorg
The first part should simplify the impl in sled-agent significantly as it will no longer need to hack around the lack of async compatibility. The second should be a simple find / replace on a few type names while accounting for some that have been moved to a dedicated crate that drives interaction with the oxide rot. The changes here will be limited accounting for code moved between crates in the dice-util repo & renaming types. All changes are backward compatible with the existing interfaces (see oxidecomputer/dice-util#445).
Keeping these two changes separate isn't strictly required but is expected to simplify review. I haven't been able to find any tests that cover this code so adding a few before making these changes would be a good way to ensure the work described here doesn't change any of the existing behavior.
Activity