Fix stable API rust impl file check (#683)

* fix: check stable API rust impl file exists at build time

When detecting Ruby versions like 3.5 (ruby-head), the build would fail
with a missing file error because is_stable() only checked version ranges
rather than verifying a corresponding ruby_X_Y.rs file exists.

Replace is_stable() with has_rust_impl() that checks for actual file
existence. This allows ruby-head or other versions without impls to
correctly fall back to compiled C when stable-api-compiled-fallback is
enabled, or error clearly when it's not.

* fix(ci): avoid installing standard gem on Ruby < 3.0

The `standard` gem version 1.52.0 dropped support for Ruby 2.7. Since we only need linting on newer Rubies, we simply skip installing and running `standard` on Ruby < 3.0.

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: ianks

Gemfile

@@ -13,7 +13,11 @@ gem "racc"
 gem "base64"
 gem "yard"
 gem "mutex_m"
-gem "standard"
+
+if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.0")
+  gem "standard", "~> 1.52.0"
+end
+
 gem "tsort"
 
 gem "ostruct", "~> 0.6.3"

Rakefile

@@ -79,7 +79,7 @@ task test: ["test:cargo", "test:gem", "test:examples"]
 desc "Pretty the files"
 task :fmt do
   sh "cargo fmt"
-  sh "bundle exec standardrb --fix" if RUBY_VERSION >= "2.7.0"
+  sh "bundle exec standardrb --fix" if RUBY_VERSION >= "3.0"
   Dir.chdir("docsite") do
     sh "npm run fmt"
   end
@@ -91,7 +91,7 @@ task format: [:fmt]
 
 desc "Lint"
 task :lint do
-  sh "bundle exec standardrb --format #{ENV.key?("CI") ? "github" : "progress"}" if RUBY_VERSION >= "2.7.0"
+  sh "bundle exec standardrb --format #{ENV.key?("CI") ? "github" : "progress"}" if RUBY_VERSION >= "3.0"
   sh "cargo fmt --check"
   sh "cargo clippy"
   sh "shellcheck $(git ls-files '*.sh')"

crates/rb-sys/build/stable_api_config.rs

@@ -4,11 +4,30 @@ use crate::{
     features::is_env_variable_defined,
     version::{Version, MIN_SUPPORTED_STABLE_VERSION},
 };
-use std::{convert::TryFrom, error::Error, path::Path};
+use std::{convert::TryFrom, error::Error, path::{Path, PathBuf}};
+
+/// Get the path to the Rust implementation file for the given Ruby version.
+fn rust_impl_path(version: Version) -> PathBuf {
+    let crate_dir = Path::new(env!("CARGO_MANIFEST_DIR"));
+    crate_dir
+        .join("src")
+        .join("stable_api")
+        .join(format!("ruby_{}_{}.rs", version.major(), version.minor()))
+}
+
+/// Check if a Rust implementation file exists for the given Ruby version.
+fn has_rust_impl(version: Version) -> bool {
+    let path = rust_impl_path(version);
+    path.exists()
+}
 
 pub fn setup(rb_config: &RbConfig) -> Result<(), Box<dyn Error>> {
     let ruby_version = Version::current(rb_config);
     let ruby_engine = rb_config.ruby_engine();
+
+    // Ensure we rebuild if the file is added or removed
+    let rust_impl_path = rust_impl_path(ruby_version);
+    println!("cargo:rerun-if-changed={}", rust_impl_path.display());
     let strategy = Strategy::try_from((ruby_engine, ruby_version))?;
 
     strategy.apply()?;
@@ -42,7 +61,7 @@ impl TryFrom<(RubyEngine, Version)> for Strategy {
             RubyEngine::Mri => {}
         }
 
-        if current_ruby_version.is_stable() {
+        if has_rust_impl(current_ruby_version) {
             strategy = Some(Strategy::RustOnly(current_ruby_version));
         } else {
             maybe_warn_old_ruby_version(current_ruby_version);
@@ -76,10 +95,10 @@ impl Strategy {
         println!("cargo:rustc-check-cfg=cfg(stable_api_has_rust_impl)");
         match self {
             Strategy::RustOnly(current_ruby_version) => {
-                if current_ruby_version.is_stable() {
+                if has_rust_impl(current_ruby_version) {
                     println!("cargo:rustc-cfg=stable_api_include_rust_impl");
                 } else {
-                    return Err(format!("A stable Ruby API is needed but could not find a candidate. If you are using a stable version of Ruby, try upgrading rb-sys. Otherwise if you are testing against ruby-head or Ruby < {}, enable the `stable-api-compiled-fallback` feature in rb-sys.", MIN_SUPPORTED_STABLE_VERSION).into());
+                    return Err(format!("No Rust stable API implementation found for Ruby {}. If you are using a stable version of Ruby, try upgrading rb-sys. Otherwise if you are testing against ruby-head or Ruby < {}, enable the `stable-api-compiled-fallback` feature in rb-sys.", current_ruby_version, MIN_SUPPORTED_STABLE_VERSION).into());
                 }
             }
             Strategy::CompiledOnly => {
@@ -88,7 +107,7 @@ impl Strategy {
                 println!("cargo:rustc-cfg=stable_api_export_compiled_as_api");
             }
             Strategy::RustThenCompiled(current_ruby_version) => {
-                if current_ruby_version.is_stable() {
+                if has_rust_impl(current_ruby_version) {
                     println!("cargo:rustc-cfg=stable_api_has_rust_impl");
                     println!("cargo:rustc-cfg=stable_api_include_rust_impl");
                 } else {
@@ -102,7 +121,7 @@ impl Strategy {
 
                 println!("cargo:rustc-cfg=stable_api_enable_compiled_mod");
 
-                if current_ruby_version.is_stable() {
+                if has_rust_impl(current_ruby_version) {
                     println!("cargo:rustc-cfg=stable_api_include_rust_impl");
                 } else {
                     println!("cargo:rustc-cfg=stable_api_export_compiled_as_api");

crates/rb-sys/build/version.rs

@@ -36,11 +36,6 @@ impl Version {
             }
         }
     }
-
-    #[allow(dead_code)]
-    pub fn is_stable(&self) -> bool {
-        *self >= MIN_SUPPORTED_STABLE_VERSION && *self <= LATEST_STABLE_VERSION
-    }
 }
 
 impl std::fmt::Display for Version {

script/show-asm

@@ -585,9 +585,9 @@ class ShowAsm
         archhdrdir = ruby_config["rubyarchhdrdir"]
 
         cmd = [cc, src_file.path,
-          "-S",                     # Output assembly
-          "-O3",                    # Optimize
-          "-fno-stack-protector",   # Disable stack canary for fair comparison
+          "-S", # Output assembly
+          "-O3", # Optimize
+          "-fno-stack-protector", # Disable stack canary for fair comparison
           "-I#{hdrdir}",
           "-I#{archhdrdir}",
           "-o", asm_file.path]