CLN: additional tests for qcut with duplicates

Author: jreback

pandas/tools/tests/test_tile.py

@@ -272,18 +272,20 @@ def test_series_retbins(self):
                                     np.array([0, 0, 1, 1], dtype=np.int8))
         tm.assert_numpy_array_equal(bins, np.array([0, 1.5, 3]))
 
-    def test_qcut_duplicates_drop(self):
+    def test_qcut_duplicates_bin(self):
         # GH 7751
         values = [0, 0, 0, 0, 1, 2, 3]
+        result_levels = ['[0, 1]', '(1, 3]']
+
         cats = qcut(values, 3, duplicates='drop')
-        ex_levels = ['[0, 1]', '(1, 3]']
-        self.assertTrue((cats.categories == ex_levels).all())
+        self.assertTrue((cats.categories == result_levels).all())
 
-    def test_qcut_duplicates_raise(self):
-        # GH 7751
-        values = [0, 0, 0, 0, 1, 2, 3]
+        self.assertRaises(ValueError, qcut, values, 3)
         self.assertRaises(ValueError, qcut, values, 3, duplicates='raise')
 
+        # invalid
+        self.assertRaises(ValueError, qcut, values, 3, duplicates='foo')
+
     def test_single_bin(self):
         # issue 14652
         expected = Series([0, 0])

pandas/tools/tile.py

@@ -208,9 +208,9 @@ def _bins_to_cuts(x, bins, right=True, labels=None,
     unique_bins = algos.unique(bins)
     if len(unique_bins) < len(bins):
         if duplicates == 'raise':
-            raise ValueError("Bin edges must be unique: {}. You "
+            raise ValueError("Bin edges must be unique: {}.\nYou "
                              "can drop duplicate edges by setting "
-                             "'duplicates' param".format(repr(bins)))
+                             "the 'duplicates' kwarg".format(repr(bins)))
         else:
             bins = unique_bins