Skip to content

Commit 1afad6f

Browse files
committed
review comments
1 parent 41ca6e7 commit 1afad6f

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

doc/source/whatsnew/v0.25.0.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ of ``object`` dtype. :attr:`Series.str` will now infer the dtype data *within* t
273273
ufuncs on Extension Dtype
274274
^^^^^^^^^^^^^^^^^^^^^^^^^
275275

276-
Operations with ``numpy`` ufuncs on Extension Arrays, including Sparse Dtypes will now coerce the
276+
Operations with ``numpy`` ufuncs on Extension Arrays, including Sparse Dtypes will now preserve the
277277
resulting dtypes to same as the input dtype; previously this would coerce to a dense dtype. (:issue:`23743`)
278278

279279
.. ipython:: python

pandas/core/series.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
from io import StringIO
66
from shutil import get_terminal_size
77
from textwrap import dedent
8-
import warnings
98
from typing import Optional, Tuple
9+
import warnings
1010

1111
import numpy as np
1212

pandas/tests/sparse/test_pivot.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import pytest
33

44
import pandas as pd
5+
from pandas import _np_version_under1p17
56
import pandas.util.testing as tm
67

78

@@ -51,7 +52,8 @@ def test_pivot_table(self):
5152
'std',
5253
'var',
5354
'sem',
54-
'median',
55+
pytest.param('median', marks=pytest.mark.xfail(
56+
not _np_version_under1p17, reason="fails on numpy > 1.16")),
5557
'first',
5658
'last'])
5759
@pytest.mark.parametrize('dropna', [True, False])

0 commit comments

Comments
 (0)