@@ -44,17 +44,21 @@ def rank_1d_{{dtype}}(object in_arr, ties_method='average', ascending=True,
44
44
45
45
{{if dtype == 'object'}}
46
46
ndarray sorted_data, values
47
+ ndarray[np.uint8_t, cast=True] sorted_namask
48
+ {{elif dtype != 'uint64'}}
49
+ ndarray[{{ctype}}] sorted_data, values
50
+ ndarray[np.uint8_t, cast=True] sorted_namask
47
51
{{else}}
48
52
ndarray[{{ctype}}] sorted_data, values
49
53
{{endif}}
50
-
54
+
51
55
ndarray[float64_t] ranks
52
56
ndarray[int64_t] argsorted
53
57
54
58
{{if dtype == 'uint64'}}
55
59
{{ctype}} val
56
60
{{else}}
57
- {{ctype}} val, nan_value
61
+ {{ctype}} val, nan_value, isnan
58
62
{{endif}}
59
63
60
64
float64_t sum_ranks = 0
@@ -121,18 +125,23 @@ def rank_1d_{{dtype}}(object in_arr, ties_method='average', ascending=True,
121
125
122
126
if not ascending:
123
127
_as = _as[::-1]
124
-
128
+
125
129
sorted_data = values.take(_as)
130
+ # need to distinguish between pos/neg nan and real nan when keep_na is true
131
+ {{if dtype != 'uint64'}}
132
+ sorted_namask = mask.take(_as)
133
+ sorted_namask = sorted_namask.astype(np.bool)
134
+ {{endif}}
126
135
argsorted = _as.astype('i8')
127
136
128
137
{{if dtype == 'object'}}
129
138
for i in range(n):
130
139
sum_ranks += i + 1
131
140
dups += 1
132
-
141
+ isnan = sorted_namask[i]
133
142
val = util.get_value_at(sorted_data, i)
134
143
135
- if (val is nan_value) and keep_na:
144
+ if isnan and keep_na:
136
145
ranks[argsorted[i]] = nan
137
146
continue
138
147
@@ -168,7 +177,8 @@ def rank_1d_{{dtype}}(object in_arr, ties_method='average', ascending=True,
168
177
val = sorted_data[i]
169
178
170
179
{{if dtype != 'uint64'}}
171
- if (val == nan_value) and keep_na:
180
+ isnan = sorted_namask[i]
181
+ if isnan and keep_na:
172
182
ranks[argsorted[i]] = nan
173
183
continue
174
184
{{endif}}
0 commit comments