Skip to content

Commit 7a2e083

Browse files
committed
fix mypy errors
1 parent 68c7064 commit 7a2e083

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

pandas/core/frame.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,13 @@
9595
from pandas.core.dtypes.missing import isna, notna
9696

9797
from pandas._typing import Axes, Dtype, FilePathOrBuffer
98-
from pandas.core import algorithms, common as com, groupby, nanops, ops
98+
from pandas.core import algorithms, common as com, nanops, ops
9999
from pandas.core.accessor import CachedAccessor
100100
from pandas.core.arrays import Categorical, ExtensionArray
101101
from pandas.core.arrays.datetimelike import DatetimeLikeArrayMixin as DatetimeLikeArray
102102
from pandas.core.arrays.sparse import SparseFrameAccessor
103103
from pandas.core.generic import NDFrame, _shared_docs
104+
from pandas.core.groupby import generic as grp_generic
104105
from pandas.core.indexes import base as ibase
105106
from pandas.core.indexes.api import Index, ensure_index, ensure_index_from_sequences
106107
from pandas.core.indexes.datetimes import DatetimeIndex
@@ -5658,13 +5659,13 @@ def groupby(
56585659
group_keys: bool = True,
56595660
squeeze: bool = False,
56605661
observed: bool = False,
5661-
) -> "groupby.DataFrameGroupBy":
5662+
) -> "grp_generic.DataFrameGroupBy":
56625663

56635664
if level is None and by is None:
56645665
raise TypeError("You have to supply one of 'by' and 'level'")
56655666
axis = self._get_axis_number(axis)
56665667

5667-
return groupby.DataFrameGroupBy(
5668+
return grp_generic.DataFrameGroupBy(
56685669
obj=self,
56695670
keys=by,
56705671
axis=axis,

pandas/core/reshape/merge.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@
4141
from pandas.core.dtypes.missing import isna, na_value_for_dtype
4242

4343
from pandas import Categorical, Index, MultiIndex
44+
from pandas._typing import FrameOrSeries
45+
from pandas.core import groupby
4446
import pandas.core.algorithms as algos
4547
from pandas.core.arrays.categorical import _recode_for_categories
4648
import pandas.core.common as com
@@ -113,6 +115,7 @@ def _groupby_and_merge(
113115
by = [by]
114116

115117
lby = left.groupby(by, sort=False)
118+
rby: Optional[groupby.DataFrameGroupBy] = None
116119

117120
# if we can groupby the rhs
118121
# then we can get vastly better perf
@@ -132,7 +135,7 @@ def _groupby_and_merge(
132135
try:
133136
rby = right.groupby(by, sort=False)
134137
except KeyError:
135-
rby = None
138+
pass
136139

137140
for key, lhs in lby:
138141

pandas/core/series.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
)
4848

4949
import pandas as pd
50-
from pandas.core import algorithms, base, generic, groupby, nanops, ops
50+
from pandas.core import algorithms, base, generic, nanops, ops
5151
from pandas.core.accessor import CachedAccessor
5252
from pandas.core.arrays import ExtensionArray, try_cast_to_ea
5353
from pandas.core.arrays.categorical import Categorical, CategoricalAccessor
@@ -60,6 +60,7 @@
6060
sanitize_array,
6161
)
6262
from pandas.core.generic import _shared_docs
63+
from pandas.core.groupby import generic as grp_generic
6364
from pandas.core.indexers import maybe_convert_indices
6465
from pandas.core.indexes.accessors import CombinedDatetimelikeProperties
6566
from pandas.core.indexes.api import (
@@ -1633,13 +1634,13 @@ def groupby(
16331634
group_keys: bool = True,
16341635
squeeze: bool = False,
16351636
observed: bool = False,
1636-
) -> "groupby.SeriesGroupBy":
1637+
) -> "grp_generic.SeriesGroupBy":
16371638

16381639
if level is None and by is None:
16391640
raise TypeError("You have to supply one of 'by' and 'level'")
16401641
axis = self._get_axis_number(axis)
16411642

1642-
return groupby.SeriesGroupBy(
1643+
return grp_generic.SeriesGroupBy(
16431644
obj=self,
16441645
keys=by,
16451646
axis=axis,

0 commit comments

Comments
 (0)