Skip to content

Commit 8492889

Browse files
committed
Merge pull request #6267 from bwignall/assert_6175_6
CLN: Converting assert_'s to specialized forms, in pandas/*/tests
2 parents 02d0cb9 + 63a002a commit 8492889

17 files changed

+153
-153
lines changed

pandas/io/tests/test_cparser.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def test_string_factorize(self):
7070
data = 'a\nb\na\nb\na'
7171
reader = TextReader(StringIO(data), header=None)
7272
result = reader.read()
73-
self.assert_(len(set(map(id, result[0]))) == 2)
73+
self.assertEqual(len(set(map(id, result[0]))), 2)
7474

7575
def test_skipinitialspace(self):
7676
data = ('a, b\n'
@@ -91,7 +91,7 @@ def test_parse_booleans(self):
9191
reader = TextReader(StringIO(data), header=None)
9292
result = reader.read()
9393

94-
self.assert_(result[0].dtype == np.bool_)
94+
self.assertEqual(result[0].dtype, np.bool_)
9595

9696
def test_delimit_whitespace(self):
9797
data = 'a b\na\t\t "b"\n"a"\t \t b'
@@ -233,25 +233,25 @@ def _make_reader(**kwds):
233233
reader = _make_reader(dtype='S5,i4')
234234
result = reader.read()
235235

236-
self.assert_(result[0].dtype == 'S5')
236+
self.assertEqual(result[0].dtype, 'S5')
237237

238238
ex_values = np.array(['a', 'aa', 'aaa', 'aaaa', 'aaaaa'], dtype='S5')
239239
self.assert_((result[0] == ex_values).all())
240-
self.assert_(result[1].dtype == 'i4')
240+
self.assertEqual(result[1].dtype, 'i4')
241241

242242
reader = _make_reader(dtype='S4')
243243
result = reader.read()
244-
self.assert_(result[0].dtype == 'S4')
244+
self.assertEqual(result[0].dtype, 'S4')
245245
ex_values = np.array(['a', 'aa', 'aaa', 'aaaa', 'aaaa'], dtype='S4')
246246
self.assert_((result[0] == ex_values).all())
247-
self.assert_(result[1].dtype == 'S4')
247+
self.assertEqual(result[1].dtype, 'S4')
248248

249249
reader = _make_reader(dtype='S4', as_recarray=True)
250250
result = reader.read()
251-
self.assert_(result['0'].dtype == 'S4')
251+
self.assertEqual(result['0'].dtype, 'S4')
252252
ex_values = np.array(['a', 'aa', 'aaa', 'aaaa', 'aaaa'], dtype='S4')
253253
self.assert_((result['0'] == ex_values).all())
254-
self.assert_(result['1'].dtype == 'S4')
254+
self.assertEqual(result['1'].dtype, 'S4')
255255

256256
def test_pass_dtype(self):
257257
data = """\
@@ -266,19 +266,19 @@ def _make_reader(**kwds):
266266

267267
reader = _make_reader(dtype={'one': 'u1', 1: 'S1'})
268268
result = reader.read()
269-
self.assert_(result[0].dtype == 'u1')
270-
self.assert_(result[1].dtype == 'S1')
269+
self.assertEqual(result[0].dtype, 'u1')
270+
self.assertEqual(result[1].dtype, 'S1')
271271

272272
reader = _make_reader(dtype={'one': np.uint8, 1: object})
273273
result = reader.read()
274-
self.assert_(result[0].dtype == 'u1')
275-
self.assert_(result[1].dtype == 'O')
274+
self.assertEqual(result[0].dtype, 'u1')
275+
self.assertEqual(result[1].dtype, 'O')
276276

277277
reader = _make_reader(dtype={'one': np.dtype('u1'),
278278
1: np.dtype('O')})
279279
result = reader.read()
280-
self.assert_(result[0].dtype == 'u1')
281-
self.assert_(result[1].dtype == 'O')
280+
self.assertEqual(result[0].dtype, 'u1')
281+
self.assertEqual(result[1].dtype, 'O')
282282

283283
def test_usecols(self):
284284
data = """\

pandas/io/tests/test_date_converters.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def test_parse_date_time(self):
5050
df = read_table(StringIO(data), sep=',', header=0,
5151
parse_dates=datecols, date_parser=conv.parse_date_time)
5252
self.assert_('date_time' in df)
53-
self.assert_(df.date_time.ix[0] == datetime(2001, 1, 5, 10, 0, 0))
53+
self.assertEqual(df.date_time.ix[0], datetime(2001, 1, 5, 10, 0, 0))
5454

5555
data = ("KORD,19990127, 19:00:00, 18:56:00, 0.8100\n"
5656
"KORD,19990127, 20:00:00, 19:56:00, 0.0100\n"
@@ -74,7 +74,7 @@ def test_parse_date_fields(self):
7474
parse_dates=datecols,
7575
date_parser=conv.parse_date_fields)
7676
self.assert_('ymd' in df)
77-
self.assert_(df.ymd.ix[0] == datetime(2001, 1, 10))
77+
self.assertEqual(df.ymd.ix[0], datetime(2001, 1, 10))
7878

7979
def test_datetime_six_col(self):
8080
result = conv.parse_all_fields(self.years, self.months, self.days,
@@ -91,7 +91,7 @@ def test_datetime_six_col(self):
9191
parse_dates=datecols,
9292
date_parser=conv.parse_all_fields)
9393
self.assert_('ymdHMS' in df)
94-
self.assert_(df.ymdHMS.ix[0] == datetime(2001, 1, 5, 10, 0, 0))
94+
self.assertEqual(df.ymdHMS.ix[0], datetime(2001, 1, 5, 10, 0, 0))
9595

9696
def test_datetime_fractional_seconds(self):
9797
data = """\
@@ -104,10 +104,10 @@ def test_datetime_fractional_seconds(self):
104104
parse_dates=datecols,
105105
date_parser=conv.parse_all_fields)
106106
self.assert_('ymdHMS' in df)
107-
self.assert_(df.ymdHMS.ix[0] == datetime(2001, 1, 5, 10, 0, 0,
108-
microsecond=123456))
109-
self.assert_(df.ymdHMS.ix[1] == datetime(2001, 1, 5, 10, 0, 0,
110-
microsecond=500000))
107+
self.assertEqual(df.ymdHMS.ix[0], datetime(2001, 1, 5, 10, 0, 0,
108+
microsecond=123456))
109+
self.assertEqual(df.ymdHMS.ix[1], datetime(2001, 1, 5, 10, 0, 0,
110+
microsecond=500000))
111111

112112
def test_generic(self):
113113
data = "year, month, day, a\n 2001, 01, 10, 10.\n 2001, 02, 1, 11."
@@ -117,7 +117,7 @@ def test_generic(self):
117117
parse_dates=datecols,
118118
date_parser=dateconverter)
119119
self.assert_('ym' in df)
120-
self.assert_(df.ym.ix[0] == date(2001, 1, 1))
120+
self.assertEqual(df.ym.ix[0], date(2001, 1, 1))
121121

122122

123123
if __name__ == '__main__':

pandas/io/tests/test_packers.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def test_timestamp(self):
194194
'20130101'), Timestamp('20130101', tz='US/Eastern'),
195195
Timestamp('201301010501')]:
196196
i_rec = self.encode_decode(i)
197-
self.assert_(i == i_rec)
197+
self.assertEqual(i, i_rec)
198198

199199
def test_datetimes(self):
200200

@@ -207,15 +207,15 @@ def test_datetimes(self):
207207
2013, 1, 1), datetime.datetime(2013, 1, 1, 5, 1),
208208
datetime.date(2013, 1, 1), np.datetime64(datetime.datetime(2013, 1, 5, 2, 15))]:
209209
i_rec = self.encode_decode(i)
210-
self.assert_(i == i_rec)
210+
self.assertEqual(i, i_rec)
211211

212212
def test_timedeltas(self):
213213

214214
for i in [datetime.timedelta(days=1),
215215
datetime.timedelta(days=1, seconds=10),
216216
np.timedelta64(1000000)]:
217217
i_rec = self.encode_decode(i)
218-
self.assert_(i == i_rec)
218+
self.assertEqual(i, i_rec)
219219

220220

221221
class TestIndex(TestPackers):

pandas/io/tests/test_parsers.py

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ def func(*date_cols):
309309
self.assert_('X3' not in df)
310310

311311
d = datetime(1999, 1, 27, 19, 0)
312-
self.assert_(df.ix[0, 'nominal'] == d)
312+
self.assertEqual(df.ix[0, 'nominal'], d)
313313

314314
df = self.read_csv(StringIO(data), header=None,
315315
date_parser=func,
@@ -342,7 +342,7 @@ def func(*date_cols):
342342
self.assert_('X3' not in df)
343343

344344
d = datetime(1999, 1, 27, 19, 0)
345-
self.assert_(df.ix[0, 'X1_X2'] == d)
345+
self.assertEqual(df.ix[0, 'X1_X2'], d)
346346

347347
df = read_csv(StringIO(data), header=None,
348348
parse_dates=[[1, 2], [1, 3]], keep_date_col=True)
@@ -363,7 +363,7 @@ def func(*date_cols):
363363
df = self.read_csv(StringIO(data), sep=',', header=None,
364364
parse_dates=[1], index_col=1)
365365
d = datetime(1999, 1, 27, 19, 0)
366-
self.assert_(df.index[0] == d)
366+
self.assertEqual(df.index[0], d)
367367

368368
def test_multiple_date_cols_int_cast(self):
369369
data = ("KORD,19990127, 19:00:00, 18:56:00, 0.8100\n"
@@ -473,11 +473,11 @@ def test_index_col_named(self):
473473
index=Index(['hello', 'world', 'foo'], name='message'))
474474
rs = self.read_csv(StringIO(data), names=names, index_col=['message'])
475475
tm.assert_frame_equal(xp, rs)
476-
self.assert_(xp.index.name == rs.index.name)
476+
self.assertEqual(xp.index.name, rs.index.name)
477477

478478
rs = self.read_csv(StringIO(data), names=names, index_col='message')
479479
tm.assert_frame_equal(xp, rs)
480-
self.assert_(xp.index.name == rs.index.name)
480+
self.assertEqual(xp.index.name, rs.index.name)
481481

482482
def test_converter_index_col_bug(self):
483483
# 1835
@@ -488,7 +488,7 @@ def test_converter_index_col_bug(self):
488488

489489
xp = DataFrame({'B': [2, 4]}, index=Index([1, 3], name='A'))
490490
tm.assert_frame_equal(rs, xp)
491-
self.assert_(rs.index.name == xp.index.name)
491+
self.assertEqual(rs.index.name, xp.index.name)
492492

493493
def test_date_parser_int_bug(self):
494494
# #3071
@@ -640,7 +640,7 @@ def test_quoting(self):
640640

641641
good_line_small = bad_line_small + '"'
642642
df = self.read_table(StringIO(good_line_small), sep='\t')
643-
self.assert_(len(df) == 3)
643+
self.assertEqual(len(df), 3)
644644

645645
def test_non_string_na_values(self):
646646
# GH3611, na_values that are not a string are an issue
@@ -1005,10 +1005,10 @@ def test_read_csv_dataframe(self):
10051005
df2 = self.read_table(self.csv1, sep=',', index_col=0,
10061006
parse_dates=True)
10071007
self.assert_(np.array_equal(df.columns, ['A', 'B', 'C', 'D']))
1008-
self.assert_(df.index.name == 'index')
1008+
self.assertEqual(df.index.name, 'index')
10091009
self.assert_(isinstance(df.index[0], (datetime, np.datetime64,
10101010
Timestamp)))
1011-
self.assert_(df.values.dtype == np.float64)
1011+
self.assertEqual(df.values.dtype, np.float64)
10121012
tm.assert_frame_equal(df, df2)
10131013

10141014
def test_read_csv_no_index_name(self):
@@ -1018,7 +1018,7 @@ def test_read_csv_no_index_name(self):
10181018
self.assert_(np.array_equal(df.columns, ['A', 'B', 'C', 'D', 'E']))
10191019
self.assert_(isinstance(df.index[0], (datetime, np.datetime64,
10201020
Timestamp)))
1021-
self.assert_(df.ix[:, ['A', 'B', 'C', 'D']].values.dtype == np.float64)
1021+
self.assertEqual(df.ix[:, ['A', 'B', 'C', 'D']].values.dtype, np.float64)
10221022
tm.assert_frame_equal(df, df2)
10231023

10241024
def test_read_table_unicode(self):
@@ -1070,7 +1070,7 @@ def test_parse_bools(self):
10701070
True,3
10711071
"""
10721072
data = self.read_csv(StringIO(data))
1073-
self.assert_(data['A'].dtype == np.bool_)
1073+
self.assertEqual(data['A'].dtype, np.bool_)
10741074

10751075
data = """A,B
10761076
YES,1
@@ -1082,15 +1082,15 @@ def test_parse_bools(self):
10821082
data = self.read_csv(StringIO(data),
10831083
true_values=['yes', 'Yes', 'YES'],
10841084
false_values=['no', 'NO', 'No'])
1085-
self.assert_(data['A'].dtype == np.bool_)
1085+
self.assertEqual(data['A'].dtype, np.bool_)
10861086

10871087
data = """A,B
10881088
TRUE,1
10891089
FALSE,2
10901090
TRUE,3
10911091
"""
10921092
data = self.read_csv(StringIO(data))
1093-
self.assert_(data['A'].dtype == np.bool_)
1093+
self.assertEqual(data['A'].dtype, np.bool_)
10941094

10951095
data = """A,B
10961096
foo,bar
@@ -1107,8 +1107,8 @@ def test_int_conversion(self):
11071107
3.0,3
11081108
"""
11091109
data = self.read_csv(StringIO(data))
1110-
self.assert_(data['A'].dtype == np.float64)
1111-
self.assert_(data['B'].dtype == np.int64)
1110+
self.assertEqual(data['A'].dtype, np.float64)
1111+
self.assertEqual(data['B'].dtype, np.int64)
11121112

11131113
def test_infer_index_col(self):
11141114
data = """A,B,C
@@ -1218,7 +1218,7 @@ def test_iterator(self):
12181218
reader = self.read_csv(StringIO(data), chunksize=1)
12191219
result = list(reader)
12201220
expected = DataFrame(dict(A = [1,4,7], B = [2,5,8], C = [3,6,9]), index=['foo','bar','baz'])
1221-
self.assert_(len(result) == 3)
1221+
self.assertEqual(len(result), 3)
12221222
tm.assert_frame_equal(pd.concat(result), expected)
12231223

12241224
def test_header_not_first_line(self):
@@ -1513,7 +1513,7 @@ def test_converters_no_implicit_conv(self):
15131513
f = lambda x: x.strip()
15141514
converter = {0: f}
15151515
df = self.read_csv(StringIO(data), header=None, converters=converter)
1516-
self.assert_(df[0].dtype == object)
1516+
self.assertEqual(df[0].dtype, object)
15171517

15181518
def test_converters_euro_decimal_format(self):
15191519
data = """Id;Number1;Number2;Text1;Text2;Number3
@@ -1523,9 +1523,9 @@ def test_converters_euro_decimal_format(self):
15231523
f = lambda x: float(x.replace(",", "."))
15241524
converter = {'Number1': f, 'Number2': f, 'Number3': f}
15251525
df2 = self.read_csv(StringIO(data), sep=';', converters=converter)
1526-
self.assert_(df2['Number1'].dtype == float)
1527-
self.assert_(df2['Number2'].dtype == float)
1528-
self.assert_(df2['Number3'].dtype == float)
1526+
self.assertEqual(df2['Number1'].dtype, float)
1527+
self.assertEqual(df2['Number2'].dtype, float)
1528+
self.assertEqual(df2['Number3'].dtype, float)
15291529

15301530
def test_converter_return_string_bug(self):
15311531
# GH #583
@@ -1536,7 +1536,7 @@ def test_converter_return_string_bug(self):
15361536
f = lambda x: float(x.replace(",", "."))
15371537
converter = {'Number1': f, 'Number2': f, 'Number3': f}
15381538
df2 = self.read_csv(StringIO(data), sep=';', converters=converter)
1539-
self.assert_(df2['Number1'].dtype == float)
1539+
self.assertEqual(df2['Number1'].dtype, float)
15401540

15411541
def test_read_table_buglet_4x_multiindex(self):
15421542
text = """ A B C D E
@@ -1659,15 +1659,15 @@ def test_parse_tz_aware(self):
16591659
# it works
16601660
result = read_csv(data, index_col=0, parse_dates=True)
16611661
stamp = result.index[0]
1662-
self.assert_(stamp.minute == 39)
1662+
self.assertEqual(stamp.minute, 39)
16631663
try:
16641664
self.assert_(result.index.tz is pytz.utc)
16651665
except AssertionError: # hello Yaroslav
16661666
arr = result.index.to_pydatetime()
16671667
result = tools.to_datetime(arr, utc=True)[0]
1668-
self.assert_(stamp.minute == result.minute)
1669-
self.assert_(stamp.hour == result.hour)
1670-
self.assert_(stamp.day == result.day)
1668+
self.assertEqual(stamp.minute, result.minute)
1669+
self.assertEqual(stamp.hour, result.hour)
1670+
self.assertEqual(stamp.day, result.day)
16711671

16721672
def test_multiple_date_cols_index(self):
16731673
data = """\
@@ -2364,7 +2364,7 @@ def test_verbose_import(self):
23642364
try:
23652365
# it works!
23662366
df = self.read_csv(StringIO(text), verbose=True)
2367-
self.assert_(buf.getvalue() == 'Filled 3 NA values in column a\n')
2367+
self.assertEqual(buf.getvalue(), 'Filled 3 NA values in column a\n')
23682368
finally:
23692369
sys.stdout = sys.__stdout__
23702370

@@ -2384,7 +2384,7 @@ def test_verbose_import(self):
23842384
try:
23852385
# it works!
23862386
df = self.read_csv(StringIO(text), verbose=True, index_col=0)
2387-
self.assert_(buf.getvalue() == 'Filled 1 NA values in column a\n')
2387+
self.assertEqual(buf.getvalue(), 'Filled 1 NA values in column a\n')
23882388
finally:
23892389
sys.stdout = sys.__stdout__
23902390

@@ -2597,8 +2597,8 @@ def test_pass_dtype(self):
25972597

25982598
result = self.read_csv(StringIO(data), dtype={'one': 'u1', 1: 'S1'},
25992599
as_recarray=True)
2600-
self.assert_(result['one'].dtype == 'u1')
2601-
self.assert_(result['two'].dtype == 'S1')
2600+
self.assertEqual(result['one'].dtype, 'u1')
2601+
self.assertEqual(result['two'].dtype, 'S1')
26022602

26032603
def test_usecols_dtypes(self):
26042604
data = """\
@@ -2765,9 +2765,9 @@ def test_euro_decimal_format(self):
27652765
3;878,158;108013,434;GHI;rez;2,735694704"""
27662766

27672767
df2 = self.read_csv(StringIO(data), sep=';', decimal=',')
2768-
self.assert_(df2['Number1'].dtype == float)
2769-
self.assert_(df2['Number2'].dtype == float)
2770-
self.assert_(df2['Number3'].dtype == float)
2768+
self.assertEqual(df2['Number1'].dtype, float)
2769+
self.assertEqual(df2['Number2'].dtype, float)
2770+
self.assertEqual(df2['Number3'].dtype, float)
27712771

27722772
def test_custom_lineterminator(self):
27732773
data = 'a,b,c~1,2,3~4,5,6'

0 commit comments

Comments
 (0)