BUG-23451 Add whatsnew and other requested changes

Author: JustinZhengBC

doc/source/whatsnew/v0.24.0.txt

@@ -1115,6 +1115,7 @@ Datetimelike
 - Bug in :func:`DataFrame.combine` with datetimelike values raising a TypeError (:issue:`23079`)
 - Bug in :func:`date_range` with frequency of ``Day`` or higher where dates sufficiently far in the future could wrap around to the past instead of raising ``OutOfBoundsDatetime`` (:issue:`14187`)
 - Bug in :class:`PeriodIndex` with attribute ``freq.n`` greater than 1 where adding a :class:`DateOffset` object would return incorrect results (:issue:`23215`)
+- Bug in :class:`Series` that interpreted string indices as lists of characters when setting datetimelike values
 
 Timedelta
 ^^^^^^^^^

pandas/core/series.py

@@ -947,10 +947,9 @@ def _set_with(self, key, value):
                 except Exception:
                     pass
 
-            if isinstance(key, str):
+            if is_scalar(key):
                 key = [key]
-
-            if not isinstance(key, (list, Series, np.ndarray, Series)):
+            elif not isinstance(key, (list, Series, np.ndarray)):
                 try:
                     key = list(key)
                 except Exception:

pandas/tests/series/test_datetime_values.py

@@ -550,7 +550,8 @@ def test_minmax_nat_dataframe(self, nat):
         assert nat.max()[0] is pd.NaT
 
     def test_set_dt_with_string_index(self):
-        from datetime import date
+        # GH 23451
         x = pd.Series([1, 2, 3], index=['Date', 'b', 'other'])
-        x.Date = date.today()
+        x['Date'] = date.today()
         assert x.Date == date.today()
+        assert x['Date'] == date.today()