Skip to content

Commit da2eac2

Browse files
committed
additional review edits
1 parent a41c72e commit da2eac2

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

pandas/core/indexes/base.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,9 @@ def __new__(cls, data=None, dtype=None, copy=False, name=None,
200200
# interval
201201
if is_interval_dtype(data) or is_interval_dtype(dtype):
202202
from .interval import IntervalIndex
203+
closed = kwargs.get('closed', None)
203204
return IntervalIndex(data, dtype=dtype, name=name, copy=copy,
204-
**kwargs)
205+
closed=closed)
205206

206207
# index-like
207208
elif isinstance(data, (np.ndarray, Index, ABCSeries)):

pandas/core/indexes/interval.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ def _simple_new(cls, left, right, closed=None, name=None, copy=False,
260260
right = _ensure_index(right, copy=copy)
261261

262262
if dtype is not None:
263-
# GH 19262
263+
# GH 19262: dtype must be an IntervalDtype to override inferred
264264
dtype = pandas_dtype(dtype)
265265
if not is_interval_dtype(dtype):
266266
msg = 'dtype must be an IntervalDtype, got {dtype}'
@@ -574,7 +574,7 @@ def from_tuples(cls, data, closed='right', name=None, copy=False,
574574
575575
Examples
576576
--------
577-
>>> pd.IntervalIndex.from_tuples([(0, 1), (1,2)])
577+
>>> pd.IntervalIndex.from_tuples([(0, 1), (1, 2)])
578578
IntervalIndex([(0, 1], (1, 2]],
579579
closed='right', dtype='interval[int64]')
580580
@@ -596,6 +596,7 @@ def from_tuples(cls, data, closed='right', name=None, copy=False,
596596
lhs = rhs = np.nan
597597
else:
598598
try:
599+
# need list of length 2 tuples, e.g. [(0, 1), (1, 2), ...]
599600
lhs, rhs = d
600601
except ValueError:
601602
msg = ('IntervalIndex.from_tuples requires tuples of '

0 commit comments

Comments
 (0)