Skip to content

Commit edf138d

Browse files
committed
feedback: broaden validation to np.str_ + allow NA fill value
1 parent db61868 commit edf138d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pandas/core/arrays/string_.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ def __setitem__(self, key, value):
283283
super().__setitem__(key, value)
284284

285285
def fillna(self, value=None, method=None, limit=None):
286-
if not isinstance(value, str):
286+
if not (isinstance(value, (str, np.str_)) or isna(value)):
287287
raise TypeError(f"{value} is not a valid fill value; must be a string")
288288
return super().fillna(value, method, limit)
289289

0 commit comments

Comments
 (0)