Skip to content

CLN: template hashtable.pyx #13786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Jul 25, 2016 · 2 comments · Fixed by #13815
Closed

CLN: template hashtable.pyx #13786

jreback opened this issue Jul 25, 2016 · 2 comments · Fixed by #13815
Labels
Clean
Milestone
0.19.0

Comments

@jreback
Copy link
Contributor

jreback commented Jul 25, 2016

use Tempita support to provide templates for routines in hashtable.pyx. Lots of duplicated code by dtype that can easily use fused types, so code generation is needed. Following along the lines of #13716 would be nice.
@jreback jreback added this to the Next Major Release milestone Jul 25, 2016
@sinhrks
Copy link
Member

sinhrks commented Jul 26, 2016

I'm going to handle. What do you think adding other dtypes like int32, etc (related to #701?).

@jreback
Copy link
Contributor Author

jreback commented Jul 26, 2016

yes int32/float32 are reasonable (but could be hone later)

@sinhrks sinhrks mentioned this issue Jul 27, 2016
Merged
3 tasks
@jreback jreback modified the milestones: 0.19.0, Next Major Release Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.19.0
Development

Successfully merging a pull request may close this issue.

BLD: use tempita for hashtable sinhrks/pandas
2 participants
@jreback @sinhrks