Skip to content

Using OrderedDict in GroupBy Module(s) #25692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WillAyd opened this issue Mar 12, 2019 · 1 comment · Fixed by #25693
Closed

Using OrderedDict in GroupBy Module(s) #25692

WillAyd opened this issue Mar 12, 2019 · 1 comment · Fixed by #25693
Labels
Groupby
Milestone
0.25.0

Comments

@WillAyd
Copy link
Member

WillAyd commented Mar 12, 2019

Spurred by conversation in #25224 (comment) right now we are using plain old dictionaries in most of the groupby aggregation functions. For Py35 this makes the order of the returned result non-deterministic.

We could theoretically make a stronger assertion around the order here by replacing those dicts with OrderedDicts
@WillAyd WillAyd mentioned this issue Mar 12, 2019
Merged
3 tasks
@alexander-ponomaroff
Copy link
Contributor

Since I've already been working with this, I will also continue with this issue. I'll make a simple WIP PR right now and will continue working on it. I'm thinking of changing the simple dicts to OrderedDicts in the aggregation functions of groupby and writing some tests in order to test the ordering.

Merged
4 tasks
@jreback jreback added this to the 0.25.0 milestone Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Groupby
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

Replace dicts with OrderedDicts in groupby aggregation functions alexander-ponomaroff/pandas
4 participants
@WillAyd @jreback @mroeschke @alexander-ponomaroff