Skip to content

ENH: use EA.argmin/argmax in EA._reduce / Series.argmin/argmax #35178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jorisvandenbossche opened this issue Jul 8, 2020 · 2 comments
Open

ENH: use EA.argmin/argmax in EA._reduce / Series.argmin/argmax #35178

jorisvandenbossche opened this issue Jul 8, 2020 · 2 comments
Labels
Closing Candidate May be closeable, needs more eyeballs Enhancement ExtensionArray Extending pandas with custom dtypes or arrays.

Comments

@jorisvandenbossche
Copy link
Member

Follow-up on #27801: that PR added ExtensionArray.argmin()/argmax() methods, but this is not yet used in the equivalent Series methods (through _reduce).

When adding this, we will need to decide on the following issues as well:
@jorisvandenbossche jorisvandenbossche added Enhancement ExtensionArray Extending pandas with custom dtypes or arrays. labels Jul 8, 2020
@jorisvandenbossche jorisvandenbossche added this to the Contributions Welcome milestone Jul 8, 2020
@jorisvandenbossche jorisvandenbossche mentioned this issue Jul 8, 2020
Merged
@TomAugspurger
Copy link
Contributor

I have a branch started for this at https://github.com/TomAugspurger/pandas/tree/32749-seriesidxminmax. Ran into the skipna returning -1 issue.

@jorisvandenbossche jorisvandenbossche mentioned this issue Sep 23, 2020
Closed
@jorisvandenbossche jorisvandenbossche mentioned this issue Nov 18, 2020
Merged
5 tasks
@jorisvandenbossche jorisvandenbossche mentioned this issue Dec 28, 2020
Merged
5 tasks
@mzeitlin11 mzeitlin11 mentioned this issue Oct 2, 2021
Closed
3 tasks
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
@jbrockmendel
Copy link
Member

Series.argmin is defined in base.IndexOpsMixin and does call delegate.argmin(). Is the idea here that going through _reduce is important?

@jbrockmendel jbrockmendel added the Closing Candidate May be closeable, needs more eyeballs label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closing Candidate May be closeable, needs more eyeballs Enhancement ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jorisvandenbossche @TomAugspurger @jbrockmendel @mroeschke