Skip to content

STYLE: Add a precommit rule that validates there is no usage in pd.api.types.<method> #39300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nofarm3 opened this issue Jan 20, 2021 · 1 comment
Closed

STYLE: Add a precommit rule that validates there is no usage in pd.api.types.<method> #39300

nofarm3 opened this issue Jan 20, 2021 · 1 comment
Assignees
@nofarm3
Labels
Code Style Code style, linting, code_checks

Comments

@nofarm3
Copy link
Contributor

nofarm3 commented Jan 20, 2021 •
edited
Loading

Followup to issue #39203

Add a precommit rule that validates there is no usage in pd.api.types.

For example:

Wrong:
pd.api.types.is_number(1)

Right:

from pandas.api.types import is_number

is_number(1)
@nofarm3 nofarm3 changed the title Add a precommit rule that validates there is no usage in pd.api.types.<method> STYLE: Add a precommit rule that validates there is no usage in pd.api.types.<method> Jan 20, 2021
@nofarm3
Copy link
Contributor Author

nofarm3 commented Jan 20, 2021

take

@simonjayhawkins simonjayhawkins added the Code Style Code style, linting, code_checks label Jan 20, 2021
@nofarm3 nofarm3 closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nofarm3 nofarm3

Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nofarm3 @simonjayhawkins