-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
WEB: Upgrade Bootstrap from v4.0 to v5.0 #41457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
take |
I've created a repo and a live site to test Bootstrap 5. Some elements such as the jumbotron were removed completely and would have to be replaced with something else. The font is also slightly different. Another big change I noticed was that all the data attributes were changed from |
Thanks for researching @calvh. Those seem like minor problems that we can take care of. Feel free to move forward. |
After some tinkering I've managed to upgrade the site to Bootstrap v5.0 while keeping it as close as possible to the original and with minimal changes to the code. You can see it live here. Here is a list of changes:
Regarding the last point, I am not sure what caused the underline to appear again. I am guessing Bootstrap had some built-in styling for Other notable points are that they changed the font in v5 and made the |
@calvh thanks for looking into this! One small thing I noticed in your live preview compared to the current site is that the page has become a bit wider. Was that on purpose? |
Your welcome! No it was not on purpose as it became wider as soon as I replaced v4 with v5. I think Bootstrap changed the size of their containers (not sure). The reason I think so is that when you open the Bootstrap website it's exactly the same width. |
Personally I think that is fine. Unless someone is an expert on front-end (I'm not), I think better to use bootstrap defaults. I assume if their new default is to make pages wider, they'll have a good reason for it. @calvh do you want to move forward and open a PR? |
Sure, thanks for your feedback Marc. I'll make a PR soon and maybe we'll get more comments there. |
Bootstrap has a new stable version v5.0. I think it is a good idea to upgrade the website to use this new version. It no longer uses jQuery (one less dependency) and new features can be utilized by developers to further improve the website.
Please share your thoughts.
related to issue #41438 and pull request #41447
The text was updated successfully, but these errors were encountered: