Skip to content

DEPR: dropping nuisance columns in BaseWindow._apply #42738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Jul 26, 2021 · 0 comments · Fixed by #42834
Closed

DEPR: dropping nuisance columns in BaseWindow._apply #42738

jbrockmendel opened this issue Jul 26, 2021 · 0 comments · Fixed by #42834
Labels
Deprecate Functionality to remove in pandas Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Window rolling, ewma, expanding
Milestone
1.4

Comments

@jbrockmendel
Copy link
Member

In BaseWindow._apply we call mgr.apply with ignore_failures=True, which causes us to silently drop columns for which the function is invalid. We have deprecated this pattern for DataFrame reductions and GroupBy reductions, should deprecate it here too.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jul 26, 2021
@mroeschke mroeschke added Deprecate Functionality to remove in pandas Window rolling, ewma, expanding Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jul 26, 2021
@jbrockmendel jbrockmendel mentioned this issue Jul 31, 2021
Merged
4 tasks
@jreback jreback added this to the 1.4 milestone Aug 5, 2021
@jbrockmendel jbrockmendel mentioned this issue Aug 23, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Window rolling, ewma, expanding
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

DEPR: dropping nuisance columns in rolling aggregations jbrockmendel/pandas
3 participants
@jreback @jbrockmendel @mroeschke