Skip to content

BUG: 32 bit build does not work with -Werror #46360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
jonashaag opened this issue Mar 14, 2022 · 5 comments
Open
3 tasks done

BUG: 32 bit build does not work with -Werror #46360

jonashaag opened this issue Mar 14, 2022 · 5 comments
Labels
32bit 32-bit systems Build Library building on various platforms

Comments

@jonashaag
Copy link
Contributor

jonashaag commented Mar 14, 2022

Pandas version checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of pandas.
  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

PANDAS_CI=1 python setup.py build_ext

Issue Description

pandas/_libs/hashtable.c: In function ‘__pyx_f_6pandas_5_libs_9hashtable_value_count_complex128’:
    pandas/_libs/hashtable.c:70107:33: error: comparison of integer expressions of different signedness: ‘Py_ssize_t’ {aka ‘int’} and ‘khuint_t’ {aka ‘unsigned int’} [-Werror=sign-compare]
    70107 |   for (__pyx_t_3 = 0; __pyx_t_3 < __pyx_t_16; __pyx_t_3+=1) {
          |                                 ^

Issue seems to be that this range has a signed int counter that is compare to an unsigned int limit:

for i in range(table.size):

@jonashaag jonashaag added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Mar 14, 2022
@DriesSchaumont
Copy link
Member

DriesSchaumont commented Mar 14, 2022

For reference: support for Linux 32bit will be dropped somewhere in the future.
xref #44453

@DriesSchaumont DriesSchaumont added Build Library building on various platforms 32bit 32-bit systems and removed Needs Triage Issue that has not been reviewed by a pandas team member Bug labels Mar 14, 2022
@jonashaag
Copy link
Contributor Author

@DriesSchaumont
Copy link
Member

Woops. My bad.

@jonashaag
Copy link
Contributor Author

But we aren't testing Windows 32 bit although that other thread says it's supported 🤔

@fangchenli
Copy link
Member

But we aren't testing Windows 32 bit although that other thread says it's supported 🤔

Overall our support for 32 bit is very flimsy. We skip/xfail some tests to make the CI green...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
32bit 32-bit systems Build Library building on various platforms
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants