Skip to content

STYLE fix PDF026 issues from pandas-dev-flaker #46528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcoGorelli opened this issue Mar 27, 2022 · 0 comments · Fixed by #46529
Closed

STYLE fix PDF026 issues from pandas-dev-flaker #46528

MarcoGorelli opened this issue Mar 27, 2022 · 0 comments · Fixed by #46529
Labels
Code Style Code style, linting, code_checks good first issue
Milestone
1.5

Comments

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Mar 27, 2022 •
edited
Loading

task is:

  1. bump version of pandas-dev-flaker in

    pandas/.pre-commit-config.yaml

    Line 53 in c3ab0c9

    - pandas-dev-flaker==0.4.0
    to 0.5.0
  2. update pandas-dev-flaker: pip install -U pandas-dev-flaker
  3. run flake8 pandas --select PDF026
  4. fix any issues that are highlighted by flake8
  5. run flake8 pandas and add any new codes to

    pandas/setup.cfg

    Line 76 in c3ab0c9

    ignore =
@MarcoGorelli MarcoGorelli added Code Style Code style, linting, code_checks good first issue labels Mar 27, 2022
@Moisan Moisan mentioned this issue Mar 27, 2022
Merged
5 tasks
@jreback jreback added this to the 1.5 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks good first issue
Projects
None yet
Milestone
1.5
Development

Successfully merging a pull request may close this issue.

STYLE: fix PDF026 issues Moisan/pandas
2 participants
@jreback @MarcoGorelli