Skip to content

DOC/DEPR: pandas.to_pickle #48402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
twoertwein opened this issue Sep 5, 2022 · 2 comments
Open

DOC/DEPR: pandas.to_pickle #48402

twoertwein opened this issue Sep 5, 2022 · 2 comments
Labels
Deprecate Functionality to remove in pandas IO Pickle read_pickle, to_pickle Needs Discussion Requires discussion from core team before further action

Comments

@twoertwein
Copy link
Member

twoertwein commented Sep 5, 2022 •
edited
Loading

to_pickle is exported in the pandas.__init__ but not documented to be accessible from there (non of the other to_<IO> functions are exported in pandas.__init__).

Should to_pickle be removed/deprecated from pandas.__init__ or should it be documented?

xref pandas-dev/pandas-stubs#206 @Dr-Irv @bashtage
@bashtage
Copy link
Contributor

bashtage commented Sep 5, 2022

It wasn't clear whether this was an accident or intentional. Since it was in the top level we decided to keep it in stubs. If this isn't really part of the API, it would probably need to be deprecated even though it isn't in the docs.

@twoertwein twoertwein added the Needs Discussion Requires discussion from core team before further action label Sep 5, 2022
@mroeschke
Copy link
Member

mroeschke commented Sep 6, 2022 •
edited
Loading

Looks like we're using and indirectly testing this in the testing utility round_trip_pickle, but it looks to be some functionality on top of pickle.dump

+1 to deprecate pd.to_pickle if it can be easily replaced in round_trip_pickle

@mroeschke mroeschke added Deprecate Functionality to remove in pandas IO Pickle read_pickle, to_pickle labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas IO Pickle read_pickle, to_pickle Needs Discussion Requires discussion from core team before further action
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bashtage @twoertwein @mroeschke