Skip to content

REF/API: EA.assert_equal #53460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue May 31, 2023 · 3 comments
Closed

REF/API: EA.assert_equal #53460

jbrockmendel opened this issue May 31, 2023 · 3 comments
Labels
API Design ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented May 31, 2023 •
edited
Loading

ATM in the extension tests we allow authors to override tm.assert_foo_equal at the test-class-level. If this is something we want to be override-able (which I'm not sure ti is), it should be at the EA/EDtype level.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels May 31, 2023
@lithomas1 lithomas1 added Testing pandas testing functions or related to the test suite API Design ExtensionArray Extending pandas with custom dtypes or arrays. and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 1, 2023
@andrewgsavage
Copy link

which I'm not sure ti is

currently pint-pandas is xfailing tests where assert_almost_equal is used as it needs chaning a bit - see #48920 Should it be overriding this instead?

@jbrockmendel
Copy link
Member Author

I don't think so. ATM the tests allow you to override assert_equal, assert_series_equal, assert_frame_equal, assert_extension_array_equal, but not assert_almost_equal.

@jbrockmendel
Copy link
Member Author

The pattern described in the OP has been removed from the tests. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbrockmendel @andrewgsavage @lithomas1