Skip to content

BUG: pandas nightly wheel requires numpy<2 #56563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 3 tasks
lesteve opened this issue Dec 19, 2023 · 4 comments · Fixed by #55739
Closed
2 of 3 tasks

BUG: pandas nightly wheel requires numpy<2 #56563

lesteve opened this issue Dec 19, 2023 · 4 comments · Fixed by #55739
Assignees
Labels
Build Library building on various platforms Compat pandas objects compatability with Numpy or Python functions
Milestone

Comments

@lesteve
Copy link
Contributor

lesteve commented Dec 19, 2023

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

conda create -n test-env python -y
conda activate test-env
dev_anaconda_url=https://pypi.anaconda.org/scientific-python-nightly-wheels/simple
pip install --pre --upgrade --timeout=60 --extra-index $dev_anaconda_url numpy pandas 
python -c 'import numpy; print(numpy.__version__)'

Outputs:

1.26.2

Issue Description

pandas nightly wheel from scientific-python-nightly-wheel requires numpy<2.

In scikit-learn we want to test against the development version of our dependencies for numpy, scipy, pandas, etc ...

From the command we were using, we were expecting that numpy development version will be installed before closely looking at the CI log and realising that we actually get numpy latest release. More context from scikit-learn/scikit-learn#27899.

I think our current approach in scikit-learn is to not pin numpy<2 in main but pin it on release branches.

Expected Behavior

Installs numpy-2.0.0.dev0 from scientific-python-nightly-wheel

Installed Versions

pandas-2.2.0.dev0+925.gac170fdc35

@lesteve lesteve added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 19, 2023
@rhshadrach rhshadrach added the Dependencies Required and optional dependencies label Dec 19, 2023
@rhshadrach
Copy link
Member

cc @lithomas1

@lithomas1
Copy link
Member

We are almost compatible with numpy 2.0 (I have some NEP 50 changes that still need to be made), so hopefully we should be able to unpin sometime by the end of this week.

@lesteve
Copy link
Contributor Author

lesteve commented Dec 19, 2023

OK thanks, no real rush from the scikit-learn side, since there is an easy work-around.

@lithomas1 lithomas1 removed the Needs Triage Issue that has not been reviewed by a pandas team member label Dec 19, 2023
@lithomas1 lithomas1 added this to the 2.2 milestone Dec 19, 2023
@lithomas1 lithomas1 added Build Library building on various platforms Compat pandas objects compatability with Numpy or Python functions and removed Bug Dependencies Required and optional dependencies labels Dec 19, 2023
@bsipocz
Copy link

bsipocz commented Dec 21, 2023

This would be really nice to have for us over at numpy-tutorials, too. As currently I cannot easily test the material with numpy 2.0 as pandas blocks installing it.

@lithomas1 lithomas1 self-assigned this Dec 21, 2023
@lithomas1 lithomas1 linked a pull request Dec 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants