-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CLN: Use assert_produces_warning instead of pytest.raises to show FutureWarning #56716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I could find this FutureWarning in test_xml.py under the method test_empty_stylesheet(val) only @natmokval @rhshadrach |
Not sure why the checks are failing even before I replace the original code with tm.assert_produces_warning? |
Yes, it's partially correct. We have another method in |
thank you for working on it @pmhatre1. |
@natmokval The checks are still failing. The main reason after debugging, I found is that the path to the stylesheet and xml is not correct. I had to give absolute path to open the xml. Also, the Future warning is not working in my case. There is no try catch if the path to stylesheet is not given. In case you want to correct me or am I missing something here? |
In some places we raise
FutureWarning
using pytest:Find and replace it with tm.assert_produces_warning
The text was updated successfully, but these errors were encountered: